Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing core's methods, options and hooks #5639

Closed
25 tasks done
mrpiotr-dev opened this issue Dec 5, 2018 · 0 comments
Closed
25 tasks done

Add missing core's methods, options and hooks #5639

mrpiotr-dev opened this issue Dec 5, 2018 · 0 comments
Assignees
@mrpiotr-dev
Labels
Status: Released TypeScript
Milestone
December 2018

Comments

@mrpiotr-dev
Copy link
Contributor

mrpiotr-dev commented Dec 5, 2018 •
edited
Loading

Description

Missing methods in Core:

  • getTranslatedPhrase
  • isColumnModificationAllowed
  • validateColumns
  • validateRows

Missing options in Core:

  • activeHeaderClassName
  • dragToScroll

Missing hooks in Core:

  • afterDrawSelection
  • afterLanguageChange
  • afterListen
  • afterMergeCells
  • afterOnCellMouseUp
  • afterRemoveCellMeta
  • afterUnlisten
  • afterUnmergeCells
  • beforeLanguageChange
  • beforeMergeCells
  • beforeOnCellMouseUp
  • beforeRemoveCellClassNames
  • beforeRemoveCellMeta
  • beforeSetRangeStartOnly
  • beforeUnmergeCells
  • modifyColumnHeaderHeight
  • modifyGetCellCoords
  • modifyRowData

Others:

  • incorrect hook name: afterBeginEdting
@mrpiotr-dev mrpiotr-dev added this to the December 2018 milestone Dec 5, 2018
@mrpiotr-dev mrpiotr-dev self-assigned this Dec 5, 2018
@mrpiotr-dev mrpiotr-dev changed the title Add missing core's options and hooks Add missing core's methods, options and hooks Dec 5, 2018
mrpiotr-dev added a commit that referenced this issue Dec 5, 2018
@mrpiotr-dev
Added: missing methods, options and hooks + correction in hook name +…
abf47b7 
… tests. #5639
@mrpiotr-dev mrpiotr-dev mentioned this issue Dec 6, 2018
Merged
1 task
mrpiotr-dev added a commit that referenced this issue Dec 6, 2018
@mrpiotr-dev
Changed type for getTranslatedPhrase. #5639
14344ec
mrpiotr-dev pushed a commit that referenced this issue Dec 6, 2018
@swistach
Added: missing methods, options and hooks + correction in hook name (#…
3ed89ea 
…5641)

* Added: missing methods, options and hooks + correction in hook name + tests. #5639

* Changed type for getTranslatedPhrase. #5639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
Status: Released TypeScript
Projects
None yet
Milestone
December 2018
Development

No branches or pull requests
2 participants
@AMBudnik @mrpiotr-dev