Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beforeTrimRows and beforeUntrimRows hooks and extra parameters for the plugin's existing hooks #5662

Closed
wszymanski opened this issue Dec 12, 2018 · 0 comments
Closed

Add beforeTrimRows and beforeUntrimRows hooks and extra parameters for the plugin's existing hooks #5662

wszymanski opened this issue Dec 12, 2018 · 0 comments
Assignees
@wszymanski
Labels
Breaking change enhancement Status: Released Trimming Plugin
Milestone
December 2018

Comments

@wszymanski
Copy link
Contributor

@wszymanski commented on Fri Dec 07 2018

Description

Hooks for trimming / untrimming rows should have the following parameters:

  • currentTrimConfig
  • destinationTrimConfig
  • trimPossible / untrimPossible
  • stateChanged
@wszymanski wszymanski self-assigned this Dec 12, 2018
@wszymanski wszymanski added this to the December 2018 milestone Dec 12, 2018
wszymanski added a commit that referenced this issue Dec 12, 2018
@wszymanski
Hooks change + tests #5662
cefe44d
wszymanski added a commit that referenced this issue Dec 12, 2018
@wszymanski
Missed change #5662
0811dcc
wszymanski added a commit that referenced this issue Dec 13, 2018
@wszymanski
Fix #5662
662acb8
wszymanski added a commit that referenced this issue Dec 14, 2018
@wszymanski
Removed unused function #5662
6227585
@wszymanski wszymanski mentioned this issue Dec 14, 2018
Merged
6 tasks
wszymanski added a commit that referenced this issue Jan 17, 2019
@wszymanski
Type definition file update #5662
b7db746
wszymanski added a commit that referenced this issue Jan 17, 2019
@wszymanski
Added beforeTrimRows and beforeUntrimRows hooks and extra paramet…
3ace35d 
…ers for the plugin's existing hooks (#5670)

### Context
<!--- Why is this change required? What problem does it solve? -->
As the title says.

### How has this been tested?
<!--- Please describe in detail how you tested your changes (doesn't apply to translations). -->

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature or improvement (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Additional language file or change to the existing one (translations)

### Related issue(s):
1. #5662

### Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the code style of this project,
- [ ] My change requires a change to the documentation.
@wszymanski wszymanski mentioned this issue Jan 25, 2019
Closed
@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
Breaking change enhancement Status: Released Trimming Plugin
Projects
None yet
Milestone
December 2018
Development

No branches or pull requests
2 participants
@wszymanski @AMBudnik