Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `beforeTrimRows` and `beforeUntrimRows` hooks and extra parameters for the plugin's existing hooks #5662

Closed
wszymanski opened this Issue Dec 12, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@wszymanski
Copy link
Member

wszymanski commented Dec 12, 2018

@wszymanski commented on Fri Dec 07 2018

Description

Hooks for trimming / untrimming rows should have the following parameters:

  • currentTrimConfig
  • destinationTrimConfig
  • trimPossible / untrimPossible
  • stateChanged

@wszymanski wszymanski self-assigned this Dec 12, 2018

@wszymanski wszymanski added this to the December 2018 milestone Dec 12, 2018

wszymanski added a commit that referenced this issue Dec 12, 2018

wszymanski added a commit that referenced this issue Dec 12, 2018

wszymanski added a commit that referenced this issue Dec 13, 2018

wszymanski added a commit that referenced this issue Dec 14, 2018

wszymanski added a commit that referenced this issue Jan 17, 2019

wszymanski added a commit that referenced this issue Jan 17, 2019

Added `beforeTrimRows` and `beforeUntrimRows` hooks and extra paramet…
…ers for the plugin's existing hooks (#5670)

### Context
<!--- Why is this change required? What problem does it solve? -->
As the title says.

### How has this been tested?
<!--- Please describe in detail how you tested your changes (doesn't apply to translations). -->

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature or improvement (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Additional language file or change to the existing one (translations)

### Related issue(s):
1. #5662

### Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the code style of this project,
- [ ] My change requires a change to the documentation.

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.