Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextMenu's menu instance causes a listener leak. #5759

Closed
mrpiotr-dev opened this issue Feb 4, 2019 · 0 comments
Closed

ContextMenu's menu instance causes a listener leak. #5759

mrpiotr-dev opened this issue Feb 4, 2019 · 0 comments
Assignees
@mrpiotr-dev
Labels
bug Context menu Plugin Dropdown menu Plugin Status: Released
Milestone
February 2019

Comments

@mrpiotr-dev
Copy link
Contributor

Description

In #4614, we introduced leak of the mousedown listener, mounted onto document.documentElement.

memoryleak_listeners

Steps to reproduce

  1. Go to a demo.
  2. Click several times on the "updateSettings" button.
  3. Click on the "destroy" button.
  4. Check in your favourite dev tools, how many mousedown listeners are still listening on document.documentElement (html node).

TIP: In chrome you can use getEventListeners(document.documentElement).mousedown.
TIP: Be sure you are on a proper frame.

Demo

https://jsfiddle.net/1m8q2fu6/

Your environment

  • Handsontable version: 0.35.0+
  • Browser Name and version: any
  • Operating System: any
@mrpiotr-dev mrpiotr-dev self-assigned this Feb 4, 2019
@mrpiotr-dev mrpiotr-dev changed the title ContextMenu's menu instance causes a listeners leak. ContextMenu's menu instance causes a listener leak. Feb 4, 2019
@wojciechczerniak wojciechczerniak added this to the February 2019 milestone Feb 6, 2019
mrpiotr-dev added a commit that referenced this issue Feb 6, 2019
@mrpiotr-dev
WIP. Added: new hook - updatePlugin to split responsibility of update…
23fb20e 
… plugins from afterUpdateSettings. #5759
mrpiotr-dev added a commit that referenced this issue Feb 7, 2019
@mrpiotr-dev
WIP. Changed: updating process of plugins. #5759
9cbda79
mrpiotr-dev added a commit that referenced this issue Feb 11, 2019
@mrpiotr-dev
WIP. Creating menuItems list on demand. #5759
884ef85
mrpiotr-dev added a commit that referenced this issue Feb 11, 2019
@mrpiotr-dev
WIP. Reverted changes in autoColumnSize, columnSorting, ganttChart an…
805fc9a 
…d undoRedo. #5759
mrpiotr-dev added a commit that referenced this issue Feb 12, 2019
@mrpiotr-dev
WIP. Builds menu items list on demand - without prepering it previous…
3ba0129 
…ly. #5759
mrpiotr-dev added a commit that referenced this issue Feb 12, 2019
@mrpiotr-dev
Changed: itemsFactory in contextMenu builds items list on demand. #5759
bb02c61
mrpiotr-dev added a commit that referenced this issue Feb 12, 2019
@mrpiotr-dev
Removed: commented line. #5759
ebfa3b6
@mrpiotr-dev mrpiotr-dev mentioned this issue Feb 13, 2019
Merged
1 task
mrpiotr-dev added a commit that referenced this issue Feb 18, 2019
@mrpiotr-dev
Changes after CR - updated docs. Added test specs. #5759
db3a225
mrpiotr-dev added a commit that referenced this issue Feb 18, 2019
@mrpiotr-dev
Merge develop into feature branch to resolve conflict in package-lock…
42932f2 
….json #5759
mrpiotr-dev pushed a commit that referenced this issue Feb 19, 2019
@swistach
ContextMenu's sub-instance shouldn't leave its listeners. (#5789)
7a7ab8e 
* WIP. Added: new hook - updatePlugin to split responsibility of update plugins from afterUpdateSettings. #5759

* WIP. Changed: updating process of plugins. #5759

* WIP. Creating menuItems list on demand. #5759

* WIP. Reverted changes in autoColumnSize, columnSorting, ganttChart and undoRedo. #5759

* WIP. Builds menu items list on demand - without prepering it previously. #5759

* Changed: itemsFactory in contextMenu builds items list on demand. #5759

* Removed: commented line. #5759

* Changes after CR - updated docs. Added test specs. #5759

* Updated package-lock.json
@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
bug Context menu Plugin Dropdown menu Plugin Status: Released
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@wojciechczerniak @AMBudnik @mrpiotr-dev