Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Expand collapsed column, is expanding also 'child' collapsed columns, except the first child #5792

Closed
benliq opened this issue Feb 14, 2019 · 8 comments

Comments

@benliq
Copy link

benliq commented Feb 14, 2019

Description

While expanding a collapsed column, it is also expanding 'child' collapsed columns, (except the first child)
Child collapsed columns should not expand or collapse while expanding/collapsing parent

Steps to reproduce

https://codepen.io/js-ziggle/pen/WQdobO

  • First collapse E and F
  • Then Collapse B
  • Now If you expand B, column E stay collapsed, but column F is expanded.

On Handsontable Pro

@AMBudnik
Copy link
Contributor

Thank you for sharing @benliq

you're right F is expanded. It happens for I and J the same, J is expanded.

@AMBudnik
Copy link
Contributor

Still happens in 7.3.0 https://jsfiddle.net/15xs34ro/

GIF

Here's 8.0.0-beta1 https://jsfiddle.net/15xs34ro/2/
The behavior is the same, but as this version introduces new hooks for the collapsing plugin it's good to check it as well.

image

@AMBudnik
Copy link
Contributor

This issue is fixed with #6716
Demo https://codepen.io/aleksandra-budnik/pen/WNQwzMo

@benliq
Copy link
Author

benliq commented Apr 17, 2020

Great! Thanks a lot @AMBudnik

@benliq benliq closed this as completed Apr 17, 2020
@AMBudnik
Copy link
Contributor

As #6716 is not a part of an officially released version yet, I'll keep the issue open.

@pnowak
Copy link
Contributor

pnowak commented May 8, 2020

In 8.0.0.-beta2-rev2 still works well - https://jsfiddle.net/8tjr9suL/4/

Zrzut ekranu 2020-05-8 o 12 21 41

@pnowak
Copy link
Contributor

pnowak commented Jul 16, 2020

Hi @benliq

I have good news! We've just released 8.0.0-beta2 that fixes the mentioned issue. We won't be closing this ticket now. It will be closed after we release the final 8.0.0 version of Handsontable.

Here’s a full list of changes https://github.com/handsontable/handsontable/releases/tag/8.0.0-beta.2
NPM https://www.npmjs.com/package/handsontable/v/8.0.0-beta.2

All feedback's appreciated. Thank you for your input.

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants