Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 7.0.0: removing change in beforeChange breaks table #5893

Closed
aaronbeall opened this issue Mar 15, 2019 · 3 comments

Comments

@aaronbeall
Copy link
Contributor

commented Mar 15, 2019

Description

As of upgrading to 7.0.0 we ran into an issue where canceling a date cell change in beforeChange breaks the table -- the cell renders stuck in edit and editing other cells doesn't work. At this point I've noticed this happens with date and autocomplete cells but not text cells. I haven't checked other cell types.

Example demo where beforeChange removes the first change:

img

Steps to reproduce

  1. Add a beforeChange hook which performs changes.splice(0, 1)
  2. Create a date or autocomplete column.
  3. Edit a cell in one of those columns and commit.

Demo

https://jsfiddle.net/vLgyojer/

Your environment

  • Handsontable version: 7.0.0
  • Browser Name and version:
  • Operating System:

@wojciechczerniak wojciechczerniak added this to the March 2019 milestone Mar 19, 2019

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Thank you for reporting and investigating the issue. You're right. The 7.0.0 is one to blame here. The editor does not close and selection gets broken.

@AMBudnik AMBudnik added the Type: Bug label Mar 21, 2019

@aaronbeall

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

In the meantime I have a workaround to set the nextValue to the prevValue in beforeChange, then in afterChange I filter out all changes where prevValue==nextValue. I would still think this should be fixed, since the docs describe using null or splice() in beforeChange which currently doesn't work for some cell types.

@wojciechczerniak wojciechczerniak modified the milestones: March 2019, May 2019 May 13, 2019

@pnowak pnowak self-assigned this May 17, 2019

pnowak added a commit that referenced this issue May 20, 2019

@pnowak pnowak referenced this issue May 20, 2019
2 of 6 tasks complete

pnowak added a commit that referenced this issue May 28, 2019

pnowak added a commit that referenced this issue Jun 6, 2019

pnowak added a commit that referenced this issue Jun 14, 2019

pnowak added a commit that referenced this issue Jun 19, 2019

Changed flow - editor is faster close, before call applyChanges in Va…
…lidateChanges function - so we change one test #5893

pnowak added a commit that referenced this issue Jun 25, 2019

pnowak added a commit that referenced this issue Jun 25, 2019

pnowak added a commit that referenced this issue Jun 26, 2019

Additional checks to handling exceptions (#6021)
* Changed flow - editor is faster close, before call applyChanges in ValidateChanges function - so we change one test #5893
@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I'm glad to see another issue fixed. Thank you Aaron :)
the fix is available in v 7.1.1.

@AMBudnik AMBudnik closed this Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.