Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.0+] Dropdown scrolling effecting table scrolling #5913

Closed
tjgambs opened this issue Mar 25, 2019 · 7 comments

Comments

@tjgambs
Copy link

commented Mar 25, 2019

Description

Scrolling inside a dropdown effects both the dropdown and the table behind it. This should instead be only scrolling the dropdown.

Steps to reproduce

  1. Open a dropdown with greater than 10 values
  2. Scroll inside that dropdown
  3. The scrolling effects both the dropdown as well as the table behind it.

Demo

https://jsfiddle.net/tjgambs/acyrwhm2/34/

example

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Chrome 73.0.3683.86, Firefox 62.0.2, Safari 12.0.3
  • Operating System: MacOS 10.14.3

In terms of replicating this issue, all browsers on MacOS have the issue as shown in the gif above: Chrome, Firefox and Safari. I haven't had any problem with Google Chrome on Linux, but when I try to use Firefox on Linux, this scrolling issue appears again.

I did some searching through your old issues and I found this issue that appears to be similar to mine: #4651

Any help regarding the issue would be greatly appreciated. Thanks.

@tjgambs tjgambs changed the title Dropdown scrolling effecting Dropdown scrolling effecting table scrolling Mar 25, 2019

@tjgambs

This comment has been minimized.

Copy link
Author

commented Mar 25, 2019

As a follow up on this issue, I have done some debugging and have found that the correct functionality exists on handsontable v1.18.1. After the update to v2.0.0, the scrolling issue begins to appear. I hope this helps.

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Really appreciate @tjgambs

I can also add that it works fine on Windows 10, but breaks on Mac.

Related #4651

@AMBudnik AMBudnik changed the title Dropdown scrolling effecting table scrolling [2.0.0+] Dropdown scrolling effecting table scrolling Mar 26, 2019

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

we've just spotted a similar issue here #4651 not sure if this is the same one or not

@tjgambs

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

Hey @AMBudnik,

Yeah, I mentioned that issue towards the bottom of my issue. #4651 appears to be experiencing the same problem as me. Thanks for looking into this. Please let me know of any leads, I can help debug on my end.

tjgambs added a commit to enodoscore/handsontable that referenced this issue Mar 26, 2019

apegadoboureghida added a commit to enodoscore/handsontable that referenced this issue Mar 26, 2019

apegadoboureghida added a commit to enodoscore/handsontable that referenced this issue Mar 26, 2019

@apegadoboureghida apegadoboureghida referenced this issue Mar 26, 2019
2 of 6 tasks complete
@tjgambs

This comment has been minimized.

Copy link
Author

commented Mar 26, 2019

Hey @AMBudnik,

@apegadoboureghida and I dug into this issue today and proposed a solution. This solution works for us, let us know if it works for you guys. Thanks.

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

would you be able to create a pull request @tjgambs?
Only then I'll be able to pass the code changes to a developer.

Nvm, just spot the #5921

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Hey @tjgambs

Thanks again Tim for sharing this issue.

The fix is available in v 7.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.