Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore changed cell selection on undo/redo #6017

Closed
wojciechczerniak opened this issue May 15, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@wojciechczerniak
Copy link
Member

commented May 15, 2019

Description

Restore changed cell selection on undo/redo.

Like spreadsheet does:
gsheet

Steps to reproduce

  1. Change cell A1
  2. Change cell B3
  3. Select cell D1
  4. Undo
  5. Undo
  6. Data is changed back, but selection stays as D1

Demo

https://jsfiddle.net/handsoncode/8ffpsqt6/

Your environment

  • Handsontable version: 7.0.3
  • Browser Name and version: Firefox
  • Operating System: OS X

@wojciechczerniak wojciechczerniak added this to the May 2019 milestone May 15, 2019

swistach added a commit that referenced this issue May 24, 2019

swistach added a commit that referenced this issue May 24, 2019

Added: validation in undoredo.onAfterChange to check if the hook has …
…no changes - eg.: if something shifted data changes before. #6017

swistach added a commit that referenced this issue May 27, 2019

swistach added a commit that referenced this issue May 30, 2019

Removed: support for CopyPaste action in afterChange's callback. Supp…
…ort for CopyPaste functionalities in UndoRedo plugin will be a part of the next stage. #6017

swistach added a commit that referenced this issue May 30, 2019

swistach added a commit that referenced this issue Jun 3, 2019

swistach added a commit that referenced this issue Jun 4, 2019

UndoRedo should track cell selection after data changes (#6030)
* Added: undoRedo stack will cache selection after data change. #6017

* Added: validation in undoredo.onAfterChange to check if the hook has no changes - eg.: if something shifted data changes before. #6017

* Added: test specs for simple track of the selection after edit. #6017

* Removed: support for CopyPaste action in afterChange's callback. Support for CopyPaste functionalities in UndoRedo plugin will be a part of the next stage. #6017

* Changed: afterChange's callback should verify changeset length first. #6017

* Changed: undo action should not undo changes in the other cells if editor is open. #6017
@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Fixed in v 7.1.0

@AMBudnik AMBudnik closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.