Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore changed cell selection on undo/redo #6017

Closed
wojciechczerniak opened this issue May 15, 2019 · 1 comment
Closed

Restore changed cell selection on undo/redo #6017

wojciechczerniak opened this issue May 15, 2019 · 1 comment
Assignees
@mrpiotr-dev
Labels
Core: Selection Plugin Status: Released Type: Improvement suggestion Undo-redo Plugin
Milestone
May 2019

Comments

@wojciechczerniak
Copy link
Contributor

Description

Restore changed cell selection on undo/redo.

Like spreadsheet does:
gsheet

Steps to reproduce

  1. Change cell A1
  2. Change cell B3
  3. Select cell D1
  4. Undo
  5. Undo
  6. Data is changed back, but selection stays as D1

Demo

https://jsfiddle.net/handsoncode/8ffpsqt6/

Your environment

  • Handsontable version: 7.0.3
  • Browser Name and version: Firefox
  • Operating System: OS X
@wojciechczerniak wojciechczerniak added this to the May 2019 milestone May 15, 2019
mrpiotr-dev added a commit that referenced this issue May 24, 2019
@mrpiotr-dev
Added: undoRedo stack will cache selection after data change. #6017
2ccd985
mrpiotr-dev added a commit that referenced this issue May 24, 2019
@mrpiotr-dev
Added: validation in undoredo.onAfterChange to check if the hook has …
d6c1071 
…no changes - eg.: if something shifted data changes before. #6017
@mrpiotr-dev mrpiotr-dev mentioned this issue May 24, 2019
Merged
1 task
mrpiotr-dev added a commit that referenced this issue May 27, 2019
@mrpiotr-dev
Added: test specs for simple track of the selection after edit. #6017
1adf527
mrpiotr-dev added a commit that referenced this issue May 30, 2019
@mrpiotr-dev
Removed: support for CopyPaste action in afterChange's callback. Supp…
11a63d4 
…ort for CopyPaste functionalities in UndoRedo plugin will be a part of the next stage. #6017
mrpiotr-dev added a commit that referenced this issue May 30, 2019
@mrpiotr-dev
Changed: afterChange's callback should verify changeset length first. #…
01a6cde 
…6017
mrpiotr-dev added a commit that referenced this issue Jun 3, 2019
@mrpiotr-dev
Changed: undo action should not undo changes in the other cells if ed…
c3a5fb9 
…itor is open. #6017
@mrpiotr-dev mrpiotr-dev mentioned this issue Jun 4, 2019
Closed
mrpiotr-dev pushed a commit that referenced this issue Jun 4, 2019
@swistach
UndoRedo should track cell selection after data changes (#6030)
fdbe60e 
* Added: undoRedo stack will cache selection after data change. #6017

* Added: validation in undoredo.onAfterChange to check if the hook has no changes - eg.: if something shifted data changes before. #6017

* Added: test specs for simple track of the selection after edit. #6017

* Removed: support for CopyPaste action in afterChange's callback. Support for CopyPaste functionalities in UndoRedo plugin will be a part of the next stage. #6017

* Changed: afterChange's callback should verify changeset length first. #6017

* Changed: undo action should not undo changes in the other cells if editor is open. #6017
@AMBudnik
Copy link
Contributor

Fixed in v 7.1.0

@wojciechczerniak wojciechczerniak mentioned this issue Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
Core: Selection Plugin Status: Released Type: Improvement suggestion Undo-redo Plugin
Projects
None yet
Milestone
May 2019
Development

No branches or pull requests
3 participants
@wojciechczerniak @AMBudnik @mrpiotr-dev