Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.1+] Cell selection on fixedRowsBottom is broken #6084

Closed
budnix opened this issue Jul 4, 2019 · 0 comments
Closed

[7.0.1+] Cell selection on fixedRowsBottom is broken #6084

budnix opened this issue Jul 4, 2019 · 0 comments
Assignees
@pnowak
Labels
Bottom rows Plugin bug Guess: A day or more Regression Issues that were created while adding new changes to the source code Status: Released
Milestone
July 2019

Comments

@budnix
Copy link
Member

budnix commented Jul 4, 2019 •
edited
Loading

Description

Cell selection on the bottom overlay (when fixedBottomRows option is set) is broken.

Steps to reproduce

  1. Go to https://jsfiddle.net/9hvedfw1/;
  2. Scroll the table horizontally to the left edge of the table;
  3. Try to select a cell which belongs to the bottom overlay (eg AK100);
  4. In result, another cell is selected and the table is scrolled in a pseudo-randomly way.

This is a regression. It seems that this bug didn't occur in version 7.0.0.

Demo

https://jsfiddle.net/9hvedfw1/

Your environment

  • Handsontable version: 7.1.0
  • Browser Name and version: Chrome 75
  • Operating System: macOS
@budnix budnix added Regression Issues that were created while adding new changes to the source code Bottom rows Plugin Guess: A day or more Priority: normal bug labels Jul 4, 2019
@budnix budnix changed the title Cell selection on fixedRowsBottom is broken [7.0.1+] Cell selection on fixedRowsBottom is broken Jul 4, 2019
@wojciechczerniak wojciechczerniak added this to the July 2019 milestone Jul 5, 2019
@pnowak pnowak self-assigned this Jul 12, 2019
pnowak added a commit that referenced this issue Jul 12, 2019
@pnowak
improved getCoords for fixedRowsBottom #6084
1dd391f
pnowak added a commit that referenced this issue Jul 16, 2019
@pnowak
Changed test #6084
0448487
@pnowak pnowak mentioned this issue Jul 16, 2019
Merged
6 tasks
pnowak added a commit that referenced this issue Jul 30, 2019
@pnowak
fixed getCell for fixedRowsBottom #6084
f4afb5c
jansiegel added a commit that referenced this issue Aug 1, 2019
@jansiegel
Modify the amount of rows/columns passed to the row and column filter…
ca5b6ce 
…s, depending on the overlay currently being used. #6084
jansiegel added a commit that referenced this issue Aug 1, 2019
@jansiegel
Revert the previous change + modify the condition for the bottom rows…
6025615 
… in isRowAfterRenderedRows. #6084
jansiegel pushed a commit that referenced this issue Aug 2, 2019
@pnowak @swistach @jansiegel
getCoords with fixedRowsBottom after scroll return appropriate coords (…
1e5ee76 
…#6112)

* improved getCoords for fixedRowsBottom #6084

* Changed test #6084

* fixed getCell for fixedRowsBottom #6084

* Modify the amount of rows/columns passed to the row and column filters, depending on the overlay currently being used. #6084

* Revert the previous change + modify the condition for the bottom rows in isRowAfterRenderedRows. #6084

* Update src/3rdparty/walkontable/test/spec/table.spec.js

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>

* Update src/3rdparty/walkontable/test/spec/table.spec.js

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>
@wojciechczerniak wojciechczerniak mentioned this issue Sep 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnowak pnowak

Labels
Bottom rows Plugin bug Guess: A day or more Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@budnix @pnowak @wojciechczerniak @AMBudnik