New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong typings in CopyPaste plugin #6102
Comments
Thank you for sharing, We'll check it out. |
Sorry, for keeping you waiting, I'm not a TypeScript expert 🐤 but asked our devs for feedback and you're 100% right - we should change that. |
sure, there you go |
…6297) * Filling definition for four hooks Filling definition with optional options for afterCreateCol (source) afterCreateRow (source) afterRemoveCol (physicalColumns , source) afterRemoveRow (physicalColumns , source) * Updated typings and JSDoc of CopyPaste (#6241) * fix: #6102 Typings for copyPaste plugin methods (#6140) fix: typed parameters of paste method in copyPaste fix: arguments for cut and copy, the js functions don't expect any params * Added: test specs for paste method. #6102 * Changed: JSDoc descriptions for the plugin and its definitions in typings file. #6102 * Replaced physicalColumns with physicalRows for afterRemoveRow and beforeRemoveRow callbacks in the settings.types.ts file.
@talamaska I'm happy to notify you that we've made a couple of improvements to the .ts file in the newest version 7.2.0 - published today. Here's a full list of changes https://handsontable.com/docs/7.2.0/tutorial-release-notes.html |
Description
I'm breaking the process of pasting with a modal dialog if the columns of the copied data are more thant my table. If the users confirms, I slice the data, and I try to perform manual paste
I'm calling
this.hotInstance.getPlugin('copyPase').paste(sliceddata)
the problem is that typescript is finding this
while in the code of the plugin i clearly see this is not the case
https://github.com/handsontable/handsontable/blob/master/src/plugins/copyPaste/copyPaste.js#L184
cut()
and
https://github.com/handsontable/handsontable/blob/master/src/plugins/copyPaste/copyPaste.js#L274
paste(pastableText = '', pastableHtml = pastableText) {
I need some whay to do it manually.
Your environment
The text was updated successfully, but these errors were encountered: