Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0-svg-PR#6593] colors order on fixed borders #6627

Closed
aninde opened this issue Jan 10, 2020 · 2 comments
Closed

[8.0.0-svg-PR#6593] colors order on fixed borders #6627

aninde opened this issue Jan 10, 2020 · 2 comments
Assignees

Comments

@aninde
Copy link
Contributor

aninde commented Jan 10, 2020

Description

Found during testing #6593.
This testing stage of 8.0.0-SVG applies to two PRs - #6593 (bug) and #6594 (fixed).

On the fixed customBorder, which is hardened in the code and corresponds to this border e.g. custom border-bottom for the fixedRowsTop bottom border
color order is displayed not according to the order specified in the requirements.

Lighter applies to darker at the same thicknesses. Yellow overlay black.
This can be seen after the event, mouse click or scrolling.
This does not appear on #6594.

Code:


customBorders.push({
                row: i,
                col: j,
                top: {
                    width: 3,
                    color: 'black',
                },
                left: {
                    width: 3,
                    color: 'black',
                  },
                  bottom: {
                    width: 3,
                    color: 'yellow',
                  },
                  right: {
                    width: 3,
                    color: 'pink',
                  }
            })

Case 1 - after clicking by mouse

Left is #6593, right is #6594
image
Screenshot 2020-01-09 at 14 15 52
Screenshot 2020-01-09 at 14 15 25

Case 2

scrolling horizontal with fixedColumnsLeft/frozen columns

Case 3

scrolling vertical with fixedRowsTop and fixedRowsBottom (maybe somebody wants use rotated table, IMHO we should fix all fixedRows)
6593-chrome-stage2

Your environment

  • Handsontable version: 8.0.0-svg-PR#6593
@aninde aninde changed the title [8.0.0.-svg-PR#6593] colors order on fixed borders [8.0.0-svg-PR#6593] colors order on fixed borders Jan 10, 2020
@warpech warpech self-assigned this Jan 14, 2020
@warpech
Copy link
Member

warpech commented Jan 14, 2020

PRs #6593 and #6594 were merged into the main SVG borders PR #6157. In the current tip of the branch (7610c6aca7e21069a23db3b9869c08922c8e0099) I can't reproduce the problem. Maybe it was fixed with other fixes?

@aninde please confirm if any of the cases 1-3 is still valid with the current PR #6157.

@aninde
Copy link
Contributor Author

aninde commented Jan 16, 2020

It is true. this issue cannot be repeated on current #6157. It only appeared on #PR6593, maybe during merging with working a PR#6594 a fix was created. We can close this issue because there is no pull request anymore where it appeared.

@aninde aninde closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants