SVG Borders - Stage 3

[aninde]

Third stage - acceptance, retests and regression test

Builds:

25.01.2020
https://gist.githack.com/aninde/10277ad24d47c3d30acabb28dfce1ef6/raw/acf47d912207662dba90b88c43080e4cc27ba709/handsontable.full.min.js

https://gist.githack.com/aninde/bd6678e760fdb4bceac2341bdde431ee/raw/f1e14c930dd4ae4d26df2709f2085027a6eb6ffd/handsontable.full.min.css

• After fixing bugs found on the second stage SVG Borders - stage 1 and stage 2 #5
  ℹ️ not checked - means TODO

Bugs founded during stage 2

1. • #6627 [8.0.0-svg-PR#6593] colors order on fixed borders
2. • #6628 [8.0.0-svg] selection, fill and autoFill covers fixedBorder or frozen-border - covers by Frozen line
3. • #6626 Cell selection on print - not in this scope, should be reported or closed and reopen.

Bugs founded during stage 3

1. • #6646 [8.0.0-svg] Loss of right border of rowHeader while scrolling when fixedRowsTop and fixedRowsBottom are enabled - will be fixed on separate PR during stage 4
2. • #6644 [8.0.0-svg] walkontable.selection e2e test do not pass only on Firefox

Tests to conduct

• Conformance to requirements of svg-borders_PR
• Testing checklist Rewrite custom borders to use SVGs insead of DIVs handsontable#6467
• Manually on codesandbox demo and local version Improve custom borders performance (SVG) handsontable#6157 (comment)
• Test performance
  • Put the performance at test, create as many borders as possible
  • Do we have performance lab test?
• Performance with and without autoColumnSize
• How does it look like on Firefox, Safari, Chrome, Edge and IE
• How does it look like on mobiles and Ipad
• Test with Bootstrap and other CSS frameworks

Retests from stage 1 handsontable/handsontable#6467 (comment)

moved to new issue #15

[aninde]

I moved issues for retest for later stage. Preferably after merge with 8.0.0.

[aninde]

Very late, because only at this stage I tested with additional bootstrap libraries. This can't happen again in the future.

[aninde]

Bugs found during this stage:

• [svg] Loss of selection border during scroling when fixed rows are enabled handsontable#6665 loss of area.highlight border during scrolling
• [svg] Support for Bootstrap handsontable#6666 Support for Bootstrap
• [svg] Borders are blurred and moved when using non-pixel values eg. rem, em like Bootstrap handsontable#6667 blur while using rem, em, Bootstrap
• [svg] selection flickers when autofill is on last column handsontable#6671 selection flickers when autofill is on last column