Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection border style configuration through the settings object #6656

Open
warpech opened this issue Jan 22, 2020 · 2 comments
Open

Selection border style configuration through the settings object #6656

warpech opened this issue Jan 22, 2020 · 2 comments

Comments

@warpech
Copy link
Member

warpech commented Jan 22, 2020

Description

Starting from version 8.0.0 (specifically from PR #6157, it is no longer possible to set a custom border color or border width of current cell, area, fill selection using CSS. (demo of how that woked in 7.x: https://jsfiddle.net/kayw7e20/1/).

This feature was not officially supported, but we are expecting that some developers used that possibility. For a while it was listed in our docs, as @wojciechczerniak writes in #6467.

A new solution requires specifying cell, area, fill selection borders using the global settings object.

Preliminary work was done in PR #6593 (now part of PR #6157) to make sure that changes in settings object are correctly re-rendered. However, the settings object does not yet allow to specify the settings upfront and this needs to be designed and developed.

It was agreed that I will do that for 8.0.0, in a separate PR from develop.

Some preliminary discussion between me and @wojciechczerniak: https://handsoncode.slack.com/archives/D93QUS3S8/p1579606981004500

@warpech
Copy link
Member Author

warpech commented Jan 23, 2020

Proposed specification of the configuration object is presented in https://kb.handsontable.com/display/HAN/Selection+highlights. It needs feedback from @wojciechczerniak, however I will tentatively start implementing it, because it was already discussed by us on Slack.

warpech added a commit that referenced this issue Feb 11, 2020
…ect (#6656)

Implemented according to the spec using prototypal inheritance in Highlight classes of Handsonable. This way this feature is totally transparent to Walkontable.
@warpech
Copy link
Member Author

warpech commented Feb 11, 2020

Implemented in the commit 45a252f, as part of the SVG borders PR #6157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants