Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svg] Loss of selection border during scroling when fixed rows are enabled #6665

Closed
aninde opened this issue Jan 27, 2020 · 6 comments
Closed
Assignees
Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code

Comments

@aninde
Copy link
Contributor

aninde commented Jan 27, 2020

Description

Sometimes top border of area.highlight is loss during scrolling.
Related to or even Case 2 of #6646

loss-selection-border-ff

Steps to reproduce

  1. Open demo (edited) https://codesandbox.io/s/happy-sanderson-1wkoh
  2. Select by rows 3,4, 5 and 5 by clicking on rowHeader.
  3. Scroll it horizontally using magic trackpad to the end, then back and forth.

Actual result

Top selection border area.highlight vanishes

Expected result

All borders should be visible.

Demo

EDIT: Update
https://codesandbox.io/s/happy-sanderson-1wkoh

Your environment

  • Handsontable version: 8.0.0-svg
  • Browser Name and version: any
  • Operating System: macOS
@aninde aninde added Fixing / Freezing Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels Jan 27, 2020
@budnix
Copy link
Member

budnix commented Jan 27, 2020

It's worth to mention that the same happens for the bottom overlay.

Kapture 2020-01-27 at 13 48 35

@warpech
Copy link
Member

warpech commented Jan 30, 2020

I managed to reproduce locally. Any kind of scrolling works for reproduction, but there must be zero fixed columns and more than 1 fixed row.

The problem is caused by bad implementation of padding in BorderRenderer. It will be fixed automatically with #6651.

@AMBudnik AMBudnik changed the title [8.0.0-svg] Loss of selection border during scroling when fixed rows are enabled [svg] Loss of selection border during scroling when fixed rows are enabled May 11, 2020
@AMBudnik AMBudnik added the bug label Jul 6, 2020
@pnowak
Copy link
Contributor

pnowak commented Aug 27, 2020

This issue isn't replicable using v8.0.0. Here's an updated demo - https://jsfiddle.net/yhwztvnx/

@AMBudnik
Copy link
Contributor

Great news @pnowak if it's solved we can close it.

@warpech
Copy link
Member

warpech commented Aug 27, 2020

As the OP says, the problem only exists on the SVG branch and still needs to be fixed there.

@warpech warpech reopened this Aug 27, 2020
@krzysztofspilka
Copy link
Member

This is an issue reported for the SVG borders project, which was rejected and won't be implemented in Handsontable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Development

No branches or pull requests

6 participants