Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0.-beta2-rev1] When there's no data headers do not hide with their columns #6851

Closed
AMBudnik opened this issue May 7, 2020 · 1 comment
Assignees
Labels
bug Hiding Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 7, 2020

Description

When there is no data headers do not hide with their columns.
It works well in 7.4.2 https://codesandbox.io/s/date-dependent-time-change-xt9bb and 8.0.0-beta1 https://codesandbox.io/s/date-dependent-time-change-81zxl

Steps to reproduce

  1. Go to https://codesandbox.io/s/date-dependent-time-change-orfsm

Result
Zrzut ekranu 2020-05-7 o 13 26 11

Expected result
Zrzut ekranu 2020-05-7 o 13 26 21

Demo

https://jsfiddle.net/handsoncode/8ffpsqt6/

Your environment

  • Handsontable version: 8.0.0.-beta2-rev1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Hiding Plugin Regression Issues that were created while adding new changes to the source code labels May 7, 2020
@wszymanski wszymanski self-assigned this May 7, 2020
wszymanski added a commit that referenced this issue May 11, 2020
wszymanski added a commit that referenced this issue May 11, 2020
@AMBudnik
Copy link
Contributor Author

Solved in 8.0.0.-beta2-rev3 https://jsfiddle.net/arp42n70/
Zrzut ekranu 2020-05-12 o 07 49 19
Tested od macOS Catalina Chrome 80, FF 76, and Safari 13.0.5 with data/no-data, automatic and context-menu hiding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hiding Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Development

No branches or pull requests

2 participants