Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta1] Data is gone if we undo removed columns #6865

Closed
AMBudnik opened this issue May 12, 2020 · 1 comment
Closed

[8.0.0.-beta1] Data is gone if we undo removed columns #6865

AMBudnik opened this issue May 12, 2020 · 1 comment
Assignees
@budnix
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release) Undo-redo Plugin

Comments

@AMBudnik
Copy link
Contributor

Description

Data is gone if we undo removed columns.
In 8.0.0.-beta2 also the headers are gone.

Steps to reproduce

  1. Remove all the columns
  2. Try to undo

Result 7.4.2
742

Result 8.0.0.-beta1
beta1

Result 8.0.0.-beta /after 6th of May
beta2

Demo

https://jsfiddle.net/ayt87jnm/ 7.4.2 (nearly OK)
https://jsfiddle.net/ayt87jnm/2/ 8.0.0.-beta1 (broken)
https://jsfiddle.net/ayt87jnm/4/ 8.0.0.-beta2-pre ([6th of May] (929b22c) (works like 8.0.0.-beta1)
https://jsfiddle.net/ayt87jnm/5/ 8.0.0.-beta2-pre ([6th of May] (81020af) (broken even worse)
https://jsfiddle.net/ayt87jnm/1/ 8.0.0.-beta2-rev3 from 11/05 (still broken)

Related issues

Your environment

  • Handsontable version: 8.0.0.-beta1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Undo-redo Plugin Regression Issues that were created while adding new changes to the source code labels May 12, 2020
@aninde aninde mentioned this issue May 12, 2020
Closed
@AMBudnik AMBudnik mentioned this issue May 12, 2020
Closed
@wszymanski wszymanski assigned budnix and unassigned wszymanski May 18, 2020
budnix added a commit that referenced this issue May 28, 2020
@budnix
Fix row sequence lost after removing all columns
593e38f 
Issue: #6865
@budnix budnix mentioned this issue May 28, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Jun 2, 2020
@budnix
Restore focus to HoT after click on the corner
589fda2 
This changes restored the original behaviour where in the 7.4.2 it was
possible to focus HoT (isListening state) by clicking the corner when
dataset is empty.

Issue: #6865
budnix added a commit that referenced this issue Jun 2, 2020
@budnix
Fix row sequence lost after removing all columns (#6947)
9c857ea 
Fix row sequence lost after removing all columns.
And restore the original behavior wherein the 7.4.2 it was
possible to focus HoT (isListening state) by clicking the corner when
a dataset is empty.

Issue: #6865
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 4, 2020

Perfect! Solved in 8.0.0-beta2-rev11 https://jsfiddle.net/AMBudnik/5zo6jLep/

ok

@AMBudnik AMBudnik closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release) Undo-redo Plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wszymanski @budnix @AMBudnik