Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta2-rev3] Focus is staying in both - in the header input and cell textarea. #6877

Closed
pnowak opened this issue May 13, 2020 · 2 comments
Closed

[8.0.0.-beta2-rev3] Focus is staying in both - in the header input and cell textarea. #6877

pnowak opened this issue May 13, 2020 · 2 comments
Assignees
@budnix
Labels
bug Regression Issues that were created while adding new changes to the source code

Comments

@pnowak
Copy link
Contributor

pnowak commented May 13, 2020 •
edited

Description

Only after the second click on the keys, the focus disappears from the input header.
May-13-2020 13-31-03

In version 8.0.0-beta.1 works well - https://jsfiddle.net/49c6bzwd/
May-13-2020 13-31-41

In 7.4.2 works well too - https://jsfiddle.net/v7Lsze4j/
May-13-2020 13-32-04

Steps to reproduce

  1. Focus in the header input
  2. Next click in the cell.

Result

Both areas are focused on.

Expected

Only the cell area should be focused on.

Demo

https://jsfiddle.net/1bxLm69y/

Your environment

  • Handsontable version: 8.0.0. beta-2-rev3
  • Browser Name and version: Chrome 80
  • Operating System: macOS Mojave
@pnowak pnowak added bug Regression Issues that were created while adding new changes to the source code labels May 13, 2020
@aninde aninde mentioned this issue May 13, 2020
Closed
@pnowak
Copy link
Contributor Author

pnowak commented May 13, 2020 •
edited

In general, the focus is stolen by the input.

Here is a demo with search plugin - https://jsfiddle.net/5vmaqsd6/
Zrzut ekranu 2020-05-13 o 15 17 53

@wszymanski wszymanski assigned budnix and unassigned wszymanski May 18, 2020
budnix added a commit that referenced this issue May 21, 2020
@budnix
Fix focus movement between focusable elements
0961392 
This is a PoC for fixing focus-related issues. It seems that the
activeElement has to be blured while editor preparation. Otherwise the
active element stays focused while interacting with an editor.

Issue: #6877
@budnix budnix mentioned this issue May 21, 2020
Merged
6 tasks
budnix added a commit that referenced this issue May 22, 2020
@budnix
Add tests
6cf3459 
Issue: #6877
budnix added a commit that referenced this issue May 25, 2020
@budnix
Fix focus movement between focusable elements (#6916)
f2d76d5 
This commit fixes focus-related issues. It seems that the
activeElement has to be blurred while editor preparation. Otherwise the
active element stays focused while interacting with an editor.

Issue: #6877
@aninde
Copy link
Contributor

aninde commented May 26, 2020

Fixed by 8.0.0-beta.2-rev8 https://jsfiddle.net/aninde/t5hoa8v3/1/
6877-rev8

https://jsfiddle.net/aninde/5geyLt0k/ 8.0.0-beta.2-rev8 (fixed) demo with search plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wszymanski @budnix @pnowak @AMBudnik @aninde