Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0.-beta2-rev1] We cannot autofill a merged cell if it's partly hidden #6878

Closed
AMBudnik opened this issue May 13, 2020 · 6 comments
Closed
Assignees
Labels
Auto fill Plugin bug Hiding Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@AMBudnik
Copy link
Contributor

Description

We cannot autofill a merged cell if it's partly hidden. The red border is visible but the value does not populate.

Steps to reproduce

  1. Try to autofill the merged cell down

Result
broken

Expected Result
ok

Demo

https://jsfiddle.net/jvLwnx43/ 7.4.2 (works well)
https://jsfiddle.net/za4pgLto/ 8.0.0.-beta1 (works well)
https://jsfiddle.net/za4pgLto/1/ 8.0.0-beta2-rev1 (broken)

Your environment

  • Handsontable version: .0.0-beta2-rev1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@wszymanski
Copy link
Contributor

Extra cases here: #6939 (review).

@wszymanski
Copy link
Contributor

wszymanski commented Jun 2, 2020

Waiting for #6939 @wojciechczerniak. There are some cases that don't work on master. I asked for help @aninde who will describe all working cases here.

@aninde
Copy link
Contributor

aninde commented Jun 2, 2020

Described here issue is still broken on latest rev10 https://jsfiddle.net/aninde/gq31uprc/1/

This bug developed over the new beta versions, it was a little more fixed each time, so great job 🙂 Among others the double borders between cells were fixed.

Unfortunately, there are still things to improve in 8.0.0-beta2-rev10.
Described here issue is still broken on latest rev10. https://jsfiddle.net/aninde/gq31uprc/1/

Every case works better during rev7.
Case 2 merged from not hidden to not hidden https://jsfiddle.net/aninde/1fya0oxt/
rev10c1

It's possible to drag horizontally autofill from mergedCells to the end of the table.
Exception: when headers are off, one line escapes after autofill from right to left of the table. I will put on a new issue
However vertical autofill works better but gives the wrong result. After dragging autofill to A10, A6 & A7 are merged together, without display, and A8-A9-A10 are merged with A2 in the display.

Case 3. merged from hidden to not hidden https://jsfiddle.net/aninde/3pw7tqon/
rev10cc2

merged cells do not display content
you cannot drag the autofill horizontally to the end of the table,
Vertical autofill from mergedCells doesn’t work also.

Case 3. partially fixed merged from not hidden to hidden https://jsfiddle.net/aninde/0w1vdjrn/
rev10c3

you cannot drag the autofill horizontally to the end of the table.
Vertical autofill is fixed. Cells from A6-A9 are merged and A2 is displayed.

Case 4 merged from hidden to hidden https://jsfiddle.net/aninde/u0n1ygpz/
rev10c4

you cannot drag the autofill horizontally to the end of the table.
Vertical autofill is broken. Cell aren’t merged and display of content is wrong.

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 5, 2020

Issue solved in 8.0.0-beta2-rev12 https://jsfiddle.net/AMBudnik/57sqLgk2/
We may experience lacking blue background, however, that is covered in other issue.

Case 2 might look odd, cause the row height changes but that is an exact behavior of 7.4.2 https://jsfiddle.net/AMBudnik/6ojrxb3c/1/

Case 3 and 4 are not fixed. They might relate to something different. We should make a separate issue for them. @aninde can you check it again with rev12? Horizontally everything's fine but vertically.. I have some doubts.

@AMBudnik AMBudnik closed this as completed Jun 5, 2020
@aninde
Copy link
Contributor

aninde commented Jun 9, 2020

I checked, IMO case 3 and 4 are also repaired in rev12
Case 3 https://jsfiddle.net/aninde/7jpkchwn/ v 8.0.0-beta2-rev12
case3-rev12

Case 4 https://jsfiddle.net/aninde/0z5wgpj4/ v 8.0.0-beta2-rev12
case4-rev12
rev12-4

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 9, 2020

True. If we autofill hidden but merged cells it makes sense 👍
Thanks for checking @aninde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto fill Plugin bug Hiding Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

No branches or pull requests

3 participants