Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta2-rev6] Invalid comment position right behind the hidden column #6896

Closed
pnowak opened this issue May 15, 2020 · 2 comments
Closed

[8.0.0.-beta2-rev6] Invalid comment position right behind the hidden column #6896

pnowak opened this issue May 15, 2020 · 2 comments
Assignees
@jansiegel
Labels
bug Comments Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code

Comments

@pnowak
Copy link
Contributor

pnowak commented May 15, 2020 •
edited

Description

If we want to add a comment in the column right behind the hidden column position of comment container has the wrong position. It is as if in the column without a hidden one.

Zrzut ekranu 2020-05-15 o 12 43 37

Work well in 7.4.2 - https://jsfiddle.net/jo50zx9n/
Zrzut ekranu 2020-05-15 o 12 43 12

and in beta.1 - https://jsfiddle.net/o7Lq6gk3/
Zrzut ekranu 2020-05-15 o 12 42 53

Steps to reproduce

  1. Select cell from column C.
  2. Add a comment by contextMenu

Demo

https://jsfiddle.net/41ksjdpe/

Your environment

  • Handsontable version: 8.0.0.-beta2-rev6]
  • Browser Name and version: Chrome 81
  • Operating System: macOS Catalina
@pnowak pnowak added bug Comments Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code labels May 15, 2020
@aninde aninde mentioned this issue May 15, 2020
Closed
@wszymanski wszymanski assigned jansiegel and unassigned wszymanski May 18, 2020
@pnowak
Copy link
Contributor Author

pnowak commented May 22, 2020

A similar issue occurs for a hidden row and fixedRowsTop.

Additionally, if we add a comment in the first visible rows when we next hover over at the cell is showed a comment value from hidden one.

May-22-2020 13-05-42

Here is a demo - https://jsfiddle.net/L6hgbp0o/

jansiegel added a commit that referenced this issue May 28, 2020
@jansiegel
- Fix a bug with the comment editor not showing up in the correct pos…
4e750bd 
…ition after a hidden row/column. #6896
@jansiegel jansiegel mentioned this issue May 28, 2020
Merged
4 tasks
jansiegel added a commit that referenced this issue Jun 1, 2020
@jansiegel
Post-CR changes #6896.
7b96fd8
jansiegel added a commit that referenced this issue Jun 2, 2020
@jansiegel
Correct renderable/visual indexes in the comments plugin. (#6953)
6774bdd 
* - Fix a bug with the comment editor not showing up in the correct position after a hidden row/column. #6896

* - Fix a bug with the comments plugin not showing the correct comment value, when the requested cell was located past a hidden row/column. #6875

* Post-CR changes #6896.
@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 4, 2020

Solved in 8.0.0-beta2-rev11 https://jsfiddle.net/AMBudnik/2csfk9pu/ for columns and https://jsfiddle.net/AMBudnik/dgfr1L9c/ for rows.

@AMBudnik AMBudnik closed this as completed Jun 4, 2020
@AMBudnik AMBudnik assigned jansiegel and unassigned jansiegel Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Comments Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wszymanski @pnowak @jansiegel @AMBudnik