Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0.-beta2-rev6] The amount of rows remains the same even when we try to add new empty rows and NestedRows are enabled. #6897

Closed
AMBudnik opened this issue May 15, 2020 · 6 comments
Assignees
Labels
bug Nested rows Plugin Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 15, 2020

Description

The issue originated here #6324
We've started with an inability to add new rows and ended up with shifting rows while adding new (empty) rows.

Steps to reproduce

  1. Select row 1 and use 'Insert row above'

Result
You still have 2 rows.
no

Expected result
There are 3 rows, one (new) is empty.
yes

Case 2

Use the same demo but load data from line 50 (nested), and comment out that data from 51 line (2D). Case results with the same issue and broken header rendering.

Demo

https://jsfiddle.net/gt6m801j/3/ 8.0.0.-beta2-rev6 (broken)
before rev6 we were not able to add a new row #6324 (broken)

EDIT: http://jsfiddle.net/aninde/gk2q4dz9/ demo v1.15.0 (fixed)
before introducing non-continous selection is was no bug after that reproduction
Related to #5133

Your environment

  • Handsontable version: 8.0.0.-beta2-rev6
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@aninde
Copy link
Contributor

aninde commented May 15, 2020

Insert row above and below never worked with nested rows #6324, however, there was an error in console. We reported that it should be grey in contextMenu #5901.

Right now, in v8.0.0-beta2-rev6 this error propagates with undo.

Case 3
New inserted row doesn't renderer and after undoing it there is script error
undo-last-inserted-row-rev6

Case 4
Adding newly inserted row override existing row similar like here #6320 when it was about inserting child row.
undoing-insert-nested-rev6

Case 5
When you add two new rows by instert via contextMenu and you undo them
Result
112345:15 TypeError: rowObj is null in console
insert-2-when-you-got-2-undo

@AMBudnik
Copy link
Contributor Author

Enabling nestedRows also breaks moving https://jsfiddle.net/gt6m801j/5/ (move any row to get the error)
Zrzut ekranu 2020-05-15 o 14 25 36

@wszymanski wszymanski assigned jansiegel and unassigned wszymanski May 18, 2020
@jansiegel
Copy link
Member

@AMBudnik I think the main issue is fixed on the current develop branch (as of ed20102), could you check if I'm correct?

As for #6897 (comment), it still doesn't work, but it needs a separate issue + checking if it's a regression.

@AMBudnik
Copy link
Contributor Author

@jansiegel

using ed20102 commit here https://jsfiddle.net/AMBudnik/h7jLak54/

I cannot use 'Insert row above' cause I get this error

Zrzut ekranu 2020-05-22 o 09 28 50

@jansiegel
Copy link
Member

@AMBudnik the js file you're using is built at 07/11/2019 19:18:08, since it's the develop branch, and it is never built (the dist directory usually contains the latest master build, now it's even older because of all the pre-8.0 releases).

@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 27, 2020

https://jsfiddle.net/AMBudnik/1kh89375/ Solved in 8.0.0.-beta2-rev8,
thanks @jansiegel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Nested rows Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

No branches or pull requests

4 participants