Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev1] Selection/autofill rectangle is half-cut when we scroll unfixed columns #6937

Closed
AMBudnik opened this issue May 26, 2020 · 2 comments
Closed

[8.0.0-beta2-rev1] Selection/autofill rectangle is half-cut when we scroll unfixed columns #6937

AMBudnik opened this issue May 26, 2020 · 2 comments
Assignees
@budnix
Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release)

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 26, 2020 •
edited

Description

Selection/autofill rectangle is half-cut when we scroll unfixed columns

Steps to reproduce

  1. Select A1
  2. Slowly scroll right

Result
The selection/autofill rectangle is half-cut.
rect

Expected result
ok

Demo

https://jsfiddle.net/AMBudnik/q4wcd3tj/ 7.4.2 (works well)
https://jsfiddle.net/AMBudnik/4jqypb2w/ 8.0.0-beta1 (works well)
https://jsfiddle.net/AMBudnik/rcy8h6g4/ 8.0.0-beta2-rev1 (broken)
https://jsfiddle.net/AMBudnik/7yfa1rhz/ 8.0.0-beta2-rev8 (still broken)

Relates issues

Your environment

  • Handsontable version: 8.0.0-beta2-rev1
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Fixing / Freezing Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels May 26, 2020
@aninde aninde mentioned this issue May 26, 2020
Closed
@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 26, 2020 •
edited

Case 2

Rows top.

Steps

  1. Select A1
  2. Slowly scroll right

Result
top

https://jsfiddle.net/AMBudnik/52y6f0a8/
8.0.0-beta2-rev1 (broken)

@budnix budnix assigned budnix and unassigned wszymanski Jun 4, 2020
budnix added a commit that referenced this issue Jun 4, 2020
@budnix
Fix selection corner cut when overlay was selected
54a91c1 
The left width and top height holder element is being expanded by the
length of the protruding corner.

Issue: #6937
@budnix budnix mentioned this issue Jun 4, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Jun 4, 2020
@budnix
Fix code comment
6ca4785 
Issue: #6937
budnix added a commit that referenced this issue Jun 5, 2020
@budnix
Fix selection corner cut when overlay was selected (#6980)
8219862 
The selection corner is cut by the holder element of the left and top 
overlay. This commit fixes the problem by expanding the width and 
height of the overlays' holders by the length/size of the protruding 
corner element.

Issue: #6937
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jun 5, 2020

Main case solved with 8.0.0-beta2-rev12 https://jsfiddle.net/AMBudnik/89qftsgc/
Zrzut ekranu 2020-06-5 o 15 16 57

Case 2 solved with 8.0.0-beta2-rev12 https://jsfiddle.net/AMBudnik/y8xn5ger/
Zrzut ekranu 2020-06-5 o 15 17 42

@AMBudnik AMBudnik closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wszymanski @budnix @AMBudnik