Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta2-rev7] When we undo removing of columns/rows selection covers too many columns/rows #6963

Closed
AMBudnik opened this issue May 29, 2020 · 4 comments
Closed

[8.0.0.-beta2-rev7] When we undo removing of columns/rows selection covers too many columns/rows #6963

AMBudnik opened this issue May 29, 2020 · 4 comments
Assignees
@budnix
Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code Undo-redo Plugin

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 29, 2020 •
edited

Description

When we undo removing of columns selection covers too many columns.

Steps to reproduce

  1. Remove columns A, B, C with context menu
  2. Undo

Result rev7 (broken)
broken

Result rev6 (works well)
ok

Demo

https://jsfiddle.net/AMBudnik/wuqysphr/ 8.0.0.-beta2-rev6 (works well)
https://jsfiddle.net/AMBudnik/u34fc1ns/ 8.0.0-beta2-rev7 (broken)
https://jsfiddle.net/AMBudnik/ybtserdL/ 8.0.0-beta2-rev10 (still broken)

Your environment

  • Handsontable version: 8.0.0.-beta2-rev7
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Undo-redo Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels May 29, 2020
@AMBudnik AMBudnik mentioned this issue May 29, 2020
Closed
@AMBudnik AMBudnik changed the title [8.0.0.-beta2-rev7] When we undo removing of columns selection covers too many columns [8.0.0.-beta2-rev7] When we undo removing of columns/rows selection covers too many columns/rows May 29, 2020
@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 29, 2020 •
edited

I've changed the title as the following rule also applies to rows.

Steps

  1. Go to https://jsfiddle.net/AMBudnik/3pzuynre/
  2. Select rows 2-5
  3. Remove them by context menu
  4. Use CMD/CTRL + Z to undo

!important

If Undo is many by context menu it works well.

@AMBudnik AMBudnik mentioned this issue May 29, 2020
Closed
@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 29, 2020 •
edited

We had problems with the selection of non-adjacent rows/columns in rev1, in rev7 it got worse. I have reported it in this topic #6964

@aninde aninde mentioned this issue May 29, 2020
Closed
@budnix budnix assigned budnix and unassigned wszymanski Jun 5, 2020
@budnix
Copy link
Member

budnix commented Jun 5, 2020

Connected with #6964

budnix added a commit that referenced this issue Jun 8, 2020
@budnix
Fix double selection for alter operations
1cdfa79 
Fix by popping out the last added selection from the selection stack.

Issue: #6963
@budnix budnix mentioned this issue Jun 8, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Jun 9, 2020
@budnix
Add tests for undoing rows and column removal
dedfc9a 
Issue: #6963
budnix added a commit that referenced this issue Jun 9, 2020
@budnix
Add missing semicolons
fb764fb 
Issue: #6963
budnix added a commit that referenced this issue Jun 9, 2020
@budnix
Fix double selection for alter operations (#6997)
8ba8fa1 
Fix double selection for altering operations after undo by popping
out the last added selection from the selection stack.

Issue: #6963
@aninde
Copy link
Contributor

aninde commented Jun 17, 2020

This issue is solved by 8.0.0-beta2-rev15 https://jsfiddle.net/aninde/cnew6ftb/

6963-rev15

@aninde aninde closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code Undo-redo Plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wszymanski @budnix @AMBudnik @aninde