Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0.-beta2-rev11] Cannot get on the merged cell by navigating with the keyboard. #6981

Closed
pnowak opened this issue Jun 4, 2020 · 2 comments
Closed

[8.0.0.-beta2-rev11] Cannot get on the merged cell by navigating with the keyboard. #6981

pnowak opened this issue Jun 4, 2020 · 2 comments
Assignees
@jansiegel
Labels
bug Hiding Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code

Comments

@pnowak
Copy link
Contributor

pnowak commented Jun 4, 2020 •
edited

Description

When we navigation by keyboard and try to open/close cell editor by Enter we can't move to the merged cell.
Jun-04-2020 15-33-44

In version 7.4.2 and beta.1 works as expected.
Jun-04-2020 15-35-44

7.4.2 - https://jsfiddle.net/04qa8nst/
8.0.0-beta.1 - https://jsfiddle.net/6qrwavdx/

Steps to reproduce

  1. Click to a cell from the first column and navigate by using Enter key.

Demo

https://jsfiddle.net/e83pf2gu/

Related issue

#6973

Your environment

  • Handsontable version: 8.0.0.-beta2-rev11
  • Browser Name and version: Chrome 83
  • Operating System:
@pnowak pnowak added bug Merge cells Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code labels Jun 4, 2020
@aninde aninde mentioned this issue Jun 4, 2020
Closed
@jansiegel jansiegel self-assigned this Jun 9, 2020
@aninde
Copy link
Contributor

aninde commented Jun 15, 2020

The ability to use Enter to move on the table is still broken in v8.0.0-beta2-rev14 comparing to 7.4.2 While navigating with arrows or tabs works the same as in 7.4.2. will not works perfectly.

rev14
enter

7.4.2
enter-7 4 2

Navigation with RIGHT arrow or TAB is still the same. Reported here #6973
right arrow
right arro-7 4 2

jansiegel added a commit that referenced this issue Jun 15, 2020
@jansiegel
- Fix a problem with traversing through partially hidden merged cells. …
a0f4ad0 
…#6981
@jansiegel jansiegel mentioned this issue Jun 15, 2020
Merged
4 tasks
jansiegel added a commit that referenced this issue Jun 16, 2020
@jansiegel
- Fix a problem with traversing through partially hidden merged cells. …
c8d8a4b 
…#6981 (#7012)
wszymanski added a commit that referenced this issue Jun 17, 2020
@wszymanski
Build revision 15 of the branch for tests. Fix a problem with travers…
0ee76a6 
…ing through partially hidden merged cells. #6981 (#7012), Fix headers size update after dbl-click on resize handler (#7018), Fix overlay desync when indexes are trimmed (#7015).
@aninde
Copy link
Contributor

aninde commented Jun 17, 2020

This issue is solved by 8.0.0-beta2rev15 https://jsfiddle.net/aninde/7hk8py4c/1/
It's possible to navigate by ENTER. Navigation with ARROWS and TAB works as in stable 7.4.2.
fix156981

@aninde aninde closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Hiding Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pnowak @jansiegel @aninde