-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0.0-beta2-rev11] Resizing rows and fast vertical scrolling breaks resizing #7038
Labels
bug
Regression
Issues that were created while adding new changes to the source code
Resizing
Plugin
Status: Released
Comments
aninde
added
bug
Freeze / Resize / Move
Regression
Issues that were created while adding new changes to the source code
labels
Jun 22, 2020
budnix
added a commit
that referenced
this issue
Jun 23, 2020
There was a problem with getting relative cell position for the TH elements. I've simplified the fallback logic by retrieving the coordinates from top (or left for rows) overlay when no other overlay exists. The previous logic assumes that header element can be part of the master overlay but it's wrong. Indeed the master overlay has rendered that elements but they are hidden by CSS (visibility: hidden). Issue: #7038
budnix
added a commit
that referenced
this issue
Jun 23, 2020
Fix by resizing the row by touching left overlay instead of master overlay. The headers of the master overlay generally are not visible (hidden from CSS) and are not interactive. Issue: #7038
budnix
added a commit
that referenced
this issue
Jun 23, 2020
Fix by resizing the column by touching top overlay instead of master overlay. The headers of the master overlay generally are not visible (hidden from CSS) and are not interactive. Issue: #7038
budnix
added a commit
that referenced
this issue
Jun 25, 2020
There was a problem with getting a relative cell position for the TH elements. I've simplified the fallback logic by retrieving the coordinates from top (or left for rows) overlay when no other overlay exists. The previous logic assumes that the header element (passed within mouseover event) can be part of the master overlay but it's wrong. Indeed the master overlay has rendered those elements but they are hidden by CSS (visibility: hidden). So it's not possible from UI to resize headers through the master overlay. I've fixed tests that wrongly resize the headers by resizing the top or left overlay. Issue: #7038
This issue is fixed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Regression
Issues that were created while adding new changes to the source code
Resizing
Plugin
Status: Released
Description
After row resizes and fast vertical scrolling resizing stopped working.
Another minor bug is that we lost console warning related to resizing cells in
8.0.0-beta2
"The provided element is not a child of the left overlay" which occurs in
v7+
andv8-beta1
https://jsfiddle.net/aninde/b3dfok96/1/
8.0.0-beta2-rev11
Steps to reproduce
Demo
https://jsfiddle.net/aninde/b3dfok96/1/ -
v8.0.0-beta2-rev11
https://jsfiddle.net/aninde/8swema3u/ -
v7.4.2
fixedhttps://jsfiddle.net/aninde/5k3e1ahr/ -
8.0.0-beta1
fixedYour environment
The text was updated successfully, but these errors were encountered: