Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev1] HOT's not highlighting the header A with a grey background when the method selectCell is called on a hidden cell #7052

Closed
AMBudnik opened this issue Jun 25, 2020 · 2 comments
Closed

[8.0.0-beta2-rev1] HOT's not highlighting the header A with a grey background when the method selectCell is called on a hidden cell #7052

AMBudnik opened this issue Jun 25, 2020 · 2 comments
Assignees
@budnix
Labels
bug Core: Selection Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release)

Comments

@AMBudnik
Copy link
Contributor

Description

Deconstructing the issue from #7051 I'm adding the issue for not highlighting the header A with a grey background when the method selectCell is called on a hidden cell.

Steps to reproduce

  1. Just open the demo

Demo

https://jsfiddle.net/ytsr4e7L/ 7.4.2 (working)
https://jsfiddle.net/ytsr4e7L/1/ 8.0.0-beta1 (wroking)
https://jsfiddle.net/ytsr4e7L/2/ 8.0.0-beta2-rev1 https://jsfiddle.net/ytsr4e7L/2/ (broken)
https://jsfiddle.net/ytsr4e7L/4/ 8.0.0-beta2-rev17 (still broken)

Your environment

  • Handsontable version: 8.0.0-beta2-rev1
  • Browser Name and version: Chrome 83
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Hiding Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels Jun 25, 2020
@budnix budnix self-assigned this Jun 25, 2020
@aninde aninde mentioned this issue Jun 25, 2020
Closed
@budnix budnix mentioned this issue Jun 26, 2020
Merged
6 tasks
@budnix
Copy link
Member

budnix commented Jun 26, 2020

This PR #7053 fixes this issue.

@AMBudnik
Copy link
Contributor Author

Fixed in 8.0.0-beta2-rev17 https://jsfiddle.net/0ervpa75/

I've tested 3 cases

  • selecting 0, 0 (as in the issue)
  • selecting 2nd column
  • selecting both columns
    All 3 cases are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Selection Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code Status: Merged (ready for release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@budnix @AMBudnik