[8.0.0-beta2-rev7] When we select cell 0,0 and hide the data clicking on column A with RMB allows us to add new rows

[AMBudnik]

Description

As mentioned in this issue #7050 there is a difference between the menu list of options when cell 0,0 is being selected.

Steps to reproduce

1. Click with RMB on the header A to open the context menu

Result 8.0.0-beta2-rev16

https://jsfiddle.net/ph4b78uk/2/ 8.0.0-beta2-rev16
https://jsfiddle.net/ph4b78uk/4/ 8.0.0-beta2-rev 7

Result 7.4.2

https://jsfiddle.net/g4xyLj32/1/ 7.4.2
https://jsfiddle.net/ph4b78uk/3/ 8.0.0-beta2-rev6

Your environment

• Handsontable version: 8.0.0-beta2-rev7
• Browser Name and version: Chrome 83
• Operating System: macOS Catalina

[aninde]

This issue is still broken on merge-candidate for 8.0.0-beta2 PR#7027 https://jsfiddle.net/aninde/u1zmbfkd/

[wszymanski]

Another example, a simpler one:

data: Handsontable.helper.createSpreadsheetData(5, 5),
rowHeaders: true,
colHeaders: true,
hiddenColumns: {
  columns: [1],
  indicators: true,
},

hot.selectCell(2, 1)

Demos did by @aninde:

https://jsfiddle.net/aninde/y64gd5zk 7.4.2
https://jsfiddle.net/aninde/gf2Lctdm 8-beta2-rev16

[budnix]

This PR #7053 fixes this issue.

[AMBudnik]

The main issue does not differ for version 8.0.0-beta2-rev18 after merging #7053 https://jsfiddle.net/Lrtehqv9/

@wszymanski 's case solved in 8.0.0-beta2-rev18 https://jsfiddle.net/e2y0fx98/

[wszymanski]

I've added my example because it is the main reason why there is no header selection (It hasn't been handled). On Handsontable 7 after a click on the corner, there was a selection on the first element, even it was hidden. Now, click on the header select all cells and all column headers should be highlighted. We talked about it here and @budnix said that he will create a separate issue for it.

Probably this issue will be good for it. I don't know if we should threaten it as a regression now.

FYI: @wojciechczerniak.

The task is not about the click on a corner, just on the header.

[wszymanski]

I think that the current behavior of the table is regression. The selectAll method selected all headers (grey highlight) in such a case on the master.

The task is not about the click on a corner, just on the header.

[wszymanski]

Related to #7063.

The task is not about the click on a corner, just on the header.

[AMBudnik]

I'm sharing additional details as this issue might have caused some misunderstanding.

First of all, as @budnix solved the selection of a header we will compare version 8.0.0-beta2-rev18 https://jsfiddle.net/emja9h6s/ with 7.4.2 https://jsfiddle.net/dnypv40j/

Settings

In this case, we load 4 rows of data and hide them all programmatically via hiddenRows settings.
At the same time, we add selectCell() method on cell 0, 0 (which is hidden).

User action

The only use action is to open a context menu using RMB on header A. And here we can see that before rev7 of 8.0.0-beta2 when we did that actions

• Insert row above
• Insert row below

are disabled, in 8.0.0-beta2-rev7 and newer those options are active.

Screenshots

Here's 8.0.0-beta2-rev18

Here's 7.4.2

Debugging

afterOnCellMouseDown logs. In both cases when we click the header we get

• 2nd parameter {row: -1, col: 0}
• 3rd paramteter <th class=​"ht__highlight">​…​</th>​

Let me know if you need a further investigation on this case.

[aninde]

Case 4

We can not add anything from the corner (top-left element)

https://jsfiddle.net/aninde/48z0jkt3/ 8.0.0-beta2-rev19
https://jsfiddle.net/aninde/o5y19s6m/ v7.4.

[aninde]

Case 1

solved #7051 (comment)

The original demo had incorrect classes. https://jsfiddle.net/aninde/c5m21px0/ - broken 8.0.0-rev16

This case is solved by 8.0.0-beta2-rev22 https://jsfiddle.net/aninde/09kg8o6q/.
The header is selected. We can't add any row from the header. Lack of bottom border is reported as a
regression.

Case 2

still works well #7051 (comment)
@wszymanski case is still fixed like it was with rev18 https://jsfiddle.net/aninde/Lasu23rg/ in rev22

Case 3

still works well #7051 (comment)

Still works well with rev22 https://jsfiddle.net/aninde/g7bpy2uj/
afterOnCellMouseDown logs look similar after clicking A header.

• 2nd parameter {row: -1, col: 0}
• 3rd paramteter <th class=​"ht__highlight ht__active_highlight">​…​​

Case 4

I need to check assumptions
#7051 (comment)
https://jsfiddle.net/aninde/yz2r49en/ - rev22

[aninde]

Ok, Case 4 is correct with assumptions described #7082 (comment) so I'm closing this regression.