Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta1-rev1] custom border is added on the wrong coordinates if data is hidden before the cell with the border #7058

Closed
AMBudnik opened this issue Jun 29, 2020 · 1 comment
Closed

[8.0.0-beta1-rev1] custom border is added on the wrong coordinates if data is hidden before the cell with the border #7058

AMBudnik opened this issue Jun 29, 2020 · 1 comment
Assignees
@wszymanski
Labels
bug Custom borders Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

Description

The custom border is added on the wrong coordinates if data is hidden before the cell with the border.

Steps to reproduce

  1. Open context menu to add any border to cell D1
  2. Click anywhere in the table

Result 8.0.0-beta1-rev1+
Border is added to F1 instead D1.
bad

Important

  • it works well if we try to add borders before hidden columns

Demo

https://jsfiddle.net/41swhont/2/ 8.0.0-beta2-rev17 (broken)
https://jsfiddle.net/41swhont/5/ 8.0.0-beta1-rev1 (broken)
https://jsfiddle.net/41swhont/4/ 8.0.0-beta1 (broken)
https://jsfiddle.net/41swhont/3/ 7.4.2 (working)

Related issues

Your environment

  • Handsontable version: 8.0.0-beta1-rev1
  • Browser Name and version: Chrome 83
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Custom borders Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code labels Jun 29, 2020
@aninde aninde mentioned this issue Jun 29, 2020
Closed
wszymanski added a commit that referenced this issue Jun 30, 2020
@wszymanski
Part of changes - basing on renderable indexes rather than visual ind…
5801d9a 
…exes for adding custom borders #7058
@wszymanski wszymanski self-assigned this Jun 30, 2020
@aninde
Copy link
Contributor

aninde commented Jul 8, 2020

I'm very glad to see that it's solved by 8.0.0-rev20 https://jsfiddle.net/aninde/tzdeob08/ in both cases. When you add border from contextMenu on cell and from colHeader.
solved-rev20

@aninde aninde closed this as completed Jul 8, 2020
@wszymanski wszymanski mentioned this issue Jul 8, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Custom borders Plugin Hiding Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wszymanski @AMBudnik @aninde