Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev19] Fixed columns and rows doesn't work while scrolling #7086

Closed
aninde opened this issue Jul 8, 2020 · 3 comments
Closed

[8.0.0-beta2-rev19] Fixed columns and rows doesn't work while scrolling #7086

aninde opened this issue Jul 8, 2020 · 3 comments
Assignees
@budnix
Labels
bug Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Scroll Status: Merged (ready for release)

Comments

@aninde
Copy link
Contributor

aninde commented Jul 8, 2020 •
edited

Description

Fixed/frozen row and columns are not fixed when scrolling in both directions without defined height and width.

This applies to:
fixedColumnLeft, freezeColumn, fixedRowsTop and fixedRowsBottom.

Steps to reproduce

Open a demo and scroll it in both directions

Actual result:
broken-fixing

Expected result:
No worse than in 7.4.2

Demo

https://jsfiddle.net/aninde/qv6aesfb/ - v.7.4.2 (solved)
https://jsfiddle.net/aninde/hm12drc7/ - 8.0.0-beta.1 (solved)
https://jsfiddle.net/aninde/qydsh63t/ - v.8.0.0-beta2-rev18 (solved)
https://jsfiddle.net/aninde/dvpxjo49/ - v.8.0.0-beta2-rev19 (broken)
https://jsfiddle.net/aninde/4tf5vbk0/ - v.8.0.0-beta2-rev20 (broken)

Your environment

  • Handsontable version: v.8.0.0-beta2-rev19
  • Browser Name and version: Firefox 78, Chrome 83, Safari
  • Operating System: macOS Catalina 10.15
@aninde aninde added bug Scroll Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code labels Jul 8, 2020
@aninde aninde mentioned this issue Jul 8, 2020
Closed
@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 8, 2020

Surprisingly, borders are correct

Zrzut ekranu 2020-07-8 o 10 13 52

@aninde
Copy link
Contributor Author

aninde commented Jul 8, 2020

And if you check the first three columns in the contextMenu, they are correctly frozen.

@jansiegel jansiegel assigned jansiegel and budnix and unassigned jansiegel Jul 8, 2020
budnix added a commit that referenced this issue Jul 10, 2020
@budnix
Stability tests for editor positioning
165cc31 
Fixed by increasing delay between test cases.

Issue: #7086
budnix added a commit that referenced this issue Jul 10, 2020
@budnix
Fix missing overlays in scrollable container
0dc2c98 
The PR #7075 while fixing double border issues introduced a new bug
which causes missing overlays when the table is scrolled. This happened
only when the window object was set as scrollable element. I reverted
usage of the `getBoundingClientRect` method as this is used to calculate
negative values to detect if the overlay has to be sticked to the client
window edge.

Additionally, this commit fixed bottom overlay which in case when the
window is set as scrollable element the overlay wasn't sticked to the
bottom of the client window. Now it behaves as the top and left overlay.

Issue: #7086
@budnix budnix mentioned this issue Jul 10, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Jul 10, 2020
@budnix
Fix overlays appearance while scrolling and fix bottom overlay positi…
6d24b71 
…oning (#7105)

The PR #7075 while fixing double border issues introduced a new bug 
which causes missing overlays when the table is scrolled. This happened
only when the window object was set as a scrollable element. I reverted
usage of the getBoundingClientRect method as this is used to calculate
negative values to detect if the overlay has to be stuck to the client window
edge.

Additionally, this PR fixes the bottom overlay which in the case when the
window is set as a scrollable element the overlay wasn't stuck to the bottom
of the client window. Now it behaves as the top and left overlay.

Issue: #7086
@aninde
Copy link
Contributor Author

aninde commented Jul 10, 2020

This issue is fixed with 8.0.0-beta2-rev22 https://jsfiddle.net/aninde/ujymfk7b/

@aninde aninde closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Scroll Status: Merged (ready for release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@budnix @jansiegel @AMBudnik @aninde