Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev13] When custom borders are added to merged cells they do not appear on the age load and cause a TypeError #7088

Closed
AMBudnik opened this issue Jul 8, 2020 · 1 comment
Closed

[8.0.0-beta2-rev13] When custom borders are added to merged cells they do not appear on the age load and cause a TypeError #7088

AMBudnik opened this issue Jul 8, 2020 · 1 comment
Assignees
@jansiegel
Labels
bug Custom borders Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 8, 2020

Description

When custom borders are added to merged cells they do not appear on the page load and cause a TypeError.

Steps to reproduce

  1. You can't see custom borders but there's an error in the console
  2. Edit any cell. You'll see the borders.

bad

Demo

https://jsfiddle.net/e8rzmkf6/2/ 7.4.2 (working)
https://jsfiddle.net/8adeb90y/ 8.0.0-beta2-rev1 (working)
https://jsfiddle.net/e8rzmkf6/1/ 8.0.0-beta2-rev13 (first broken)
https://jsfiddle.net/0fr43dgm/1/ 8.0.0-beta2-rev20 (still broken)

Your environment

  • Handsontable version: 8.0.0-beta2-rev13
  • Browser Name and version: Chrome 83
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Custom borders Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code labels Jul 8, 2020
@aninde aninde mentioned this issue Jul 8, 2020
Closed
@jansiegel jansiegel self-assigned this Jul 8, 2020
jansiegel added a commit that referenced this issue Jul 8, 2020
@jansiegel
- Fix a problem with an error being thrown, when there were custom bo…
8481b28 
…rders declared at initialization alongside merged cells. #7088
@jansiegel jansiegel mentioned this issue Jul 8, 2020
Merged
4 tasks
jansiegel added a commit that referenced this issue Jul 8, 2020
@jansiegel
- Fix a problem with an error being thrown, when there were custom bo…
83dcf9c 
…rders declared at initialization alongside merged cells. #7088 (#7090)
wszymanski added a commit that referenced this issue Jul 9, 2020
@wszymanski
Build revision 21 of the branch for tests. Fix the editor misalign (#…
bc5eaee 
…7084). Make the row resize hooks not use `null` as a row height. (#7085). Fix a problem with an error being thrown, when there were custom borders declared at initialization alongside merged cells. #7088 (#7090).
@AMBudnik
Copy link
Contributor Author

Issue is fixed in 8.0.0-beta2-rev21 https://jsfiddle.net/zn2tcwx7/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Custom borders Plugin Merge cells Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jansiegel @AMBudnik