Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2] no lower border on headers when all rows are trimmed, hidden or filtered #7106

Closed
aninde opened this issue Jul 10, 2020 · 5 comments
Closed

[8.0.0-beta2] no lower border on headers when all rows are trimmed, hidden or filtered #7106

aninde opened this issue Jul 10, 2020 · 5 comments
Assignees
@budnix
Labels
bug Headers Status: Merged (ready for release) Trimming Plugin

Comments

@aninde
Copy link
Contributor

aninde commented Jul 10, 2020 •
edited

Description

There is no lower border on headers when all rows are trimmed.

Actual result
Screenshot 2020-07-10 at 15 09 44

Expected result
rev21 and rev1
Screenshot 2020-07-10 at 15 15 07
Screenshot 2020-07-10 at 15 16 28

Demo

https://jsfiddle.net/aninde/5rx8kwLf/ 8.0.0-beta2-rev22 - (broken)
https://jsfiddle.net/aninde/kd453gs9/ 8.0.0-beta2-rev21 - (solved)
https://jsfiddle.net/aninde/bw2uckvx/ 8.0.0-beta2-rev1 - (solved)
https://jsfiddle.net/aninde/cjw2p6ma/ - 7.4.2 - (solved)

Your environment

  • Handsontable version: 8.0.0-beta2-rev22
  • Browser Name and version: Firefox 78, Chrome 83
  • Operating System: macOS
@aninde aninde added bug Headers Trimming Plugin Regression Issues that were created while adding new changes to the source code labels Jul 10, 2020
@aninde aninde mentioned this issue Jul 10, 2020
Closed
@budnix budnix self-assigned this Jul 10, 2020
@aninde
Copy link
Contributor Author

aninde commented Jul 10, 2020

Case 2
There is no lower border on headers when all rows are hidden, so I change the title.
https://jsfiddle.net/aninde/0a1w94zx/

@aninde aninde changed the title [8.0.0-beta2-rev22] no lower border on headers when all rows are trimmed [8.0.0-beta2-rev22] no lower border on headers when all rows are trimmed or hidden Jul 10, 2020
budnix added a commit that referenced this issue Jul 13, 2020
@budnix
Fix missing bottom border
0e27e70 
This commit fixed missing border bottom in a case when the table rows
are trimmed or hidden. In terms of the Walkontable it does not matter as
in both cases total renderable rows are equal to 0. The source of the
problem was the CSS rule controlled by separate overlays which
overwrites the border bottom width alternately.

Issue: #7106
@budnix budnix mentioned this issue Jul 13, 2020
Merged
6 tasks
budnix added a commit that referenced this issue Jul 14, 2020
@budnix
Fix missing bottom border (#7109)
3075b43 
This commit fixes missing overlay bottom border in a case when the table rows
are trimmed or hidden. In terms of the Walkontable, it does not matter as in
both cases total renderable rows are equal to 0. The source of the problem
was the CSS rule controlled by separate overlays that overwrite the 
border-bottom-width alternately. After CSS rule unification, the issue is gone.

Issue: #7106
@aninde aninde changed the title [8.0.0-beta2-rev22] no lower border on headers when all rows are trimmed or hidden [8.0.0-beta2-rev22] no lower border on headers when all rows are trimmed, hidden or filtered Jul 14, 2020
@aninde
Copy link
Contributor Author

aninde commented Jul 14, 2020

Case 3
When all cells are filtered https://jsfiddle.net/aninde/b7cu2tLn/
Screenshot 2020-07-14 at 14 31 57

@aninde
Copy link
Contributor Author

aninde commented Jul 14, 2020

Case 4
When we remove all row or all columns by contextMenu from the corner or when we select all by CMD + A.
https://jsfiddle.net/7rpdehmj/
Screenshot 2020-07-14 at 15 28 34

@aninde
Copy link
Contributor Author

aninde commented Jul 16, 2020

This issue is solved by pre-8.0.0-rev1.

Case 1
https://jsfiddle.net/aninde/q9eym36h/
Screenshot 2020-07-16 at 16 51 29

Case 2
https://jsfiddle.net/aninde/5foekbsr/
Screenshot 2020-07-16 at 16 52 16

Case 3
https://jsfiddle.net/aninde/buvx0e58/
Screenshot 2020-07-16 at 16 53 00

Case 4
https://jsfiddle.net/aninde/yj48qLfr/1/
Screenshot 2020-07-16 at 16 54 22

@aninde aninde changed the title [8.0.0-beta2-rev22] no lower border on headers when all rows are trimmed, hidden or filtered [8.0.0-beta2] no lower border on headers when all rows are trimmed, hidden or filtered Jul 16, 2020
@aninde aninde removed the Regression Issues that were created while adding new changes to the source code label Jul 16, 2020
@aninde
Copy link
Contributor Author

aninde commented Jul 17, 2020

I am closing it as a regression on version 8.0.0-beta.2. Cannot be reproduced on the stable 7+ version.

@aninde aninde closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Headers Status: Merged (ready for release) Trimming Plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@budnix @aninde