Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.3.2] 2 e2e tests doesn't pass on Firefox 86 #7593

Closed
aninde opened this issue Feb 26, 2021 · 3 comments
Closed

[8.3.2] 2 e2e tests doesn't pass on Firefox 86 #7593

aninde opened this issue Feb 26, 2021 · 3 comments

Comments

@aninde
Copy link
Contributor

aninde commented Feb 26, 2021

Description

They also do not work when released separately.
I compared it with the current master, they are regression.
In both tests, results are the same.

it('should trim whitespaces from the beginning and the end of the cell when trimWhitespace options is true', () => {
handsontable({
trimWhitespace: true,
data: [
[' text with spaces ']
],
});

it('should preserve whitespaces when trimWhitespace options is false', () => {
handsontable({
trimWhitespace: false,
data: [
[' text with spaces ']
],
});

Screenshot 2021-02-26 at 13 26 37

Current master on FF 86
Screenshot 2021-02-26 at 15 48 28

Your environment

  • Handsontable version: 8.3.2
  • Browser Name and version: Firefox 86
  • Operating System: macOS 11.2.1 & Windows 10
@aninde aninde added bug Regression Issues that were created while adding new changes to the source code Firefox Tests: E2E labels Feb 26, 2021
@wojciechczerniak
Copy link
Contributor

IMO not a problem with the product, it's an issue with the test code.

@Osky772 outerText is not supported by Firefox: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/outerText

@Osky772 Osky772 self-assigned this Mar 1, 2021
@wojciechczerniak wojciechczerniak added this to the March 2021 milestone Mar 11, 2021
Osky772 added a commit that referenced this issue Mar 12, 2021
* tests: fix tests to use supported in all browsers "innerText" (#7593)

* changelog
@mrpiotr-dev mrpiotr-dev removed Regression Issues that were created while adding new changes to the source code bug labels Apr 21, 2021
@aninde
Copy link
Contributor Author

aninde commented May 5, 2021

Fixed by v8.4.0.

@AMBudnik
Copy link
Contributor

I close this issue as solved in Handsontale v8.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants