Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] BottomOverlay #8761

Closed
Tracked by #8760
Siemienik opened this issue Sep 28, 2021 · 2 comments
Closed
Tracked by #8760

[RTL] BottomOverlay #8761

Siemienik opened this issue Sep 28, 2021 · 2 comments
Labels
Core: Walkontable Plugin RTL Right-to-left Status: Released

Comments

@Siemienik
Copy link
Contributor

Siemienik commented Sep 28, 2021 •
edited

Description

When I set dir='rtl' the bottom overlay displayed incorrectly on the left of the website. It should display on the right, below the table.

Steps to reproduce

Following this configuration

configurations.FixedRowsBottom = {
    data: Handsontable.helper.createSpreadsheetData(60, 10),
    licenseKey: "non-commercial-and-evaluation",
    fixedRowsBottom: 1
};

I got:
image
This was referenced Sep 28, 2021
Closed
Closed
Closed
@Siemienik Siemienik added Core: Walkontable Plugin RTL Right-to-left labels Sep 30, 2021
Siemienik added a commit that referenced this issue Nov 16, 2021
@Siemienik
Set correct position for TopOverlay when RTL mode
e166e52 
resolves #8761
@Siemienik Siemienik linked a pull request Nov 16, 2021 that will close this issue
[RTL] Minor fixes for Top and Bottom overlays #8940
Closed
5 tasks
@Siemienik Siemienik mentioned this issue Nov 16, 2021
Closed
5 tasks
@budnix budnix mentioned this issue Jan 11, 2022
Merged
4 tasks
@warpech warpech mentioned this issue Jan 27, 2022
Closed
@aninde
Copy link
Contributor

aninde commented Mar 14, 2022

Fixed with v12.0.0 https://jsfiddle.net/fedn304g/

@AMBudnik
Copy link
Contributor

Closed with #8760 and developed and done in Handsontable v12.

For more information please check out our Release Notes - https://handsontable.com/docs/release-notes/#_12-0-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core: Walkontable Plugin RTL Right-to-left Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RTL] Minor fixes for Top and Bottom overlays handsontable/handsontable
3 participants
@Siemienik @AMBudnik @aninde