Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze the Vue dev dependency to ~2.6 #9629

Merged
merged 3 commits into from Jul 6, 2022
Merged

Conversation

budnix
Copy link
Member

@budnix budnix commented Jul 5, 2022

Context

The recently released Vue2 framework with version 2.7 introduced some changes in TypeScript typings that cause errors in our component compiling process. While preparing and testing the fix for the component I've noticed that the change is not backward-compatible, and does not work with Vue <=2.6. The fix needs more time to investigate. That's why this PR proposes a faster fix/workaround. The current version of the component already works in both Vue versions (2.6 and 2.7). To fix the monorepo build workflow I propose to freeze the dev dependencies of the vue and vue-template-compiler packages to ~2.6 (<2.7).

How has this been tested?

I tested the changes locally by executing npm run in vue build command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. Vue wrapper build script fails with Vue 2.7 #9624

Affected project(s):

  • @handsontable/vue

Checklist:

@budnix budnix self-assigned this Jul 5, 2022
@budnix budnix marked this pull request as ready for review July 5, 2022 07:22
@budnix budnix requested a review from wszymanski July 5, 2022 07:24
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Launch the local version of documentation by running:

npm run docs:review 33e196c69d3989c787f625b86cd26c0ae055a114

@budnix budnix merged commit a1d3a36 into develop Jul 6, 2022
@budnix budnix deleted the feature/issue-9624-v2 branch July 6, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants