Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling nestedRows prevents the updateData()'s dataset replacement #9844

Closed
AMBudnik opened this issue Aug 30, 2022 · 5 comments
Closed

Enabling nestedRows prevents the updateData()'s dataset replacement #9844

AMBudnik opened this issue Aug 30, 2022 · 5 comments

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 30, 2022

Description

Enabling nestedRows prevents the updateData()'s dataset replacement. The nested object dataset and non-nested dataset behave differently, so I document two cases scenarios.

Case 1

Non-nested data

  1. Go to http://jsfiddle.net/5a61smpw/3/
  2. Check the preview (correct)

Screenshot 2022-08-30 at 10 11 31

3. Comment out the `loadData()` call from line `8` and remove comment from line `9` 4. Check the preview (*wrong*) (unaltered dataset)

Screenshot 2022-08-30 at 10 12 32

Result
The number of columns is correct, but data is not replaced.

Case 2

Nested data

  1. Go to https://jsfiddle.net/ve06rdk4/
  2. Check the preview (correct)
    Screenshot 2022-08-30 at 10 08 12
  3. Comment out the loadData() call from line 172 and remove comment from line 173
  4. Check the preview (wrong) (unaltered dataset)
    Screenshot 2022-08-30 at 10 09 49

Result
The number of columns is incorrect, data is not replaced.

Your environment

  • Handsontable version: 12.1.2
  • Browser name and version: Chrome 104
  • Operating system: macOS Monterey

Inform forum

@adrianszymanski89
Copy link
Contributor

Inform Forum

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Nov 4, 2022

Inform ZD 30853.

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Dec 7, 2022

Inform ZD 31225.

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Feb 7, 2023

This issue is fixed in Handsontable v12.3.1.
Here is the full list of changes in this version https://handsontable.com/docs/javascript-data-grid/release-notes/#_12-3-1

@AMBudnik AMBudnik closed this as completed Feb 7, 2023
@aaronbeall
Copy link
Contributor

Thank you for this fix, it's a big deal to us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants