Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keyboard navigation in headers #10301

Merged
merged 82 commits into from
Jun 14, 2023
Merged

Implement keyboard navigation in headers #10301

merged 82 commits into from
Jun 14, 2023

Commits on Mar 1, 2023

  1. Unlock selection highlight to be able to navigate within headers

    @budnix
    budnix committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8489108 View commit details
    Browse the repository at this point in the history

  2. Update header selection styling and add changelog entry file

    @budnix
    budnix committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    53c4ba8 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. [wip] Unify the selection/highlight types 

    Extract the selection rendering code to the separate module.
    @budnix
    budnix committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3ee22f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Create Scanner module for WoT selections

    @budnix
    budnix committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fb208e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Fix all selection edge cases reported by the tests

    @budnix
    budnix committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d2232bb View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Decouple Border module from Selection API 

    Cleanup the code, complete code documentation, fix lint complains.
    @budnix
    budnix committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    9454283 View commit details
    Browse the repository at this point in the history

  2. Fix linter complains

    @budnix
    budnix committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a60b219 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Add missing code docs

    @budnix
    budnix committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a280312 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Update Walkontable E2E tests 

    This includes:
 * Update tests to use new internal API for selection;
 * Fix AsciiTable matcher. For now it support nested rows and columns;
 * Add new E2E tests for different Selection types;
    @budnix
    budnix committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    815c956 View commit details
    Browse the repository at this point in the history

  2. Allow using asciiTable by the Walkontable tests

    @budnix
    budnix committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    353c468 View commit details
    Browse the repository at this point in the history

  3. Fix overlays sizing when the Selection API does not exist

    @budnix
    budnix committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    ab2ea43 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Clean up the code, complete code docs

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    16c58c3 View commit details
    Browse the repository at this point in the history

  2. Remove isCell method call

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    036f9c5 View commit details
    Browse the repository at this point in the history

  3. Fix linter complains

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    fa6a2be View commit details
    Browse the repository at this point in the history

  4. Clean up the code and revert removed CellRange methods

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2fa4c00 View commit details
    Browse the repository at this point in the history

  5. Add unit tests for Selection class improve others one

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1710a60 View commit details
    Browse the repository at this point in the history

  6. Extract table's E2E tests to separate files

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    43dffd0 View commit details
    Browse the repository at this point in the history

  7. Add E2E tests for new Wot Table class methods

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    526b98a View commit details
    Browse the repository at this point in the history

  8. Add tests for new Core methods

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    51990ca View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/accessibility' into feature/dev-issue-1062

    @budnix
    budnix committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    441ea16 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Optimize elements scanning

    @budnix
    budnix committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    829f7c0 View commit details
    Browse the repository at this point in the history

  2. Remove selection limits

    @budnix
    budnix committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    15913aa View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Unlock ability to navigate in headers

    @budnix
    budnix committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    4176f8c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Fix focus selection in headers in some cases and add unit tests for 

    Transformer
    @budnix
    budnix committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    db64b12 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Cover transformStart Transformation class with new unit tests

    @budnix
    budnix committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4aee810 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Implement the PoC of the navigableHeaders option 

    ...add more unit tests and atomize the keboard shortcuts to have easier
individual implementations for shortcuts in headers.
    @budnix
    budnix committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    fd2ad7f View commit details
    Browse the repository at this point in the history

  2. Fix transformEnd method and add unit tests

    @budnix
    budnix committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6d2bc95 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Fix shortcuts context switching 

    ...move grid shortcuts to the shortcotContexts dir, fix some E2E tests.
    @budnix
    budnix committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    387bcc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Fix selection issues pointed by failing E2E tests

    @budnix
    budnix committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5d47b96 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'feature/accessibility' into feature/dev-issue-1062-part2

    @budnix
    budnix committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    dc18360 View commit details
    Browse the repository at this point in the history

  2. Add support for row/col Transform modifiers 

    Mostly used by MergeCells plugin for controlling the navigation
direction withij the merged cells.
    @budnix
    budnix committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    826a895 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/dev-issue-1062-part2' of github.com:handsontabl… 

    …e/handsontable into feature/dev-issue-1062-part2
    @budnix
    budnix committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aae99f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Activate/Restore the correct shortcut context depends on the selection

    @budnix
    budnix committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0bbcdea View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Fix isEntireSelected/isSelectedByHeader kind methods

    @budnix
    budnix committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    aafa69a View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add support for selectionMode='single' option

    @budnix
    budnix committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    79902d4 View commit details
    Browse the repository at this point in the history

  2. Disable headers selection when header is selected

    @budnix
    budnix committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d7a664e View commit details
    Browse the repository at this point in the history

  3. Fix selection expanding when header is only selected

    @budnix
    budnix committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8ae3888 View commit details
    Browse the repository at this point in the history

  4. Withdraw from the idea of adding 'headers' shortcut context

    @budnix
    budnix committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    253523b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Add support for selecting rows/columns/cells when nav in headers is on

    @budnix
    budnix committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6df59b3 View commit details
    Browse the repository at this point in the history

  2. Add E2E tests for the selectColumns method

    @budnix
    budnix committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c87f394 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Cover the selectRows method with tests

    @budnix
    budnix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    744a233 View commit details
    Browse the repository at this point in the history

  2. Cover the selectCells method with tests

    @budnix
    budnix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6c387e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Fix toEqualCellRange jasmine matcher

    @budnix
    budnix committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b28cb52 View commit details
    Browse the repository at this point in the history

  2. Fix toEqualCellRange matcher logic

    @budnix
    budnix committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4234648 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate tests

    @budnix
    budnix committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3705bb2 View commit details
    Browse the repository at this point in the history

  4. Cover with tests more Selection module methods

    @budnix
    budnix committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    10223ff View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Cover the containsHeaders method with tests and fix others

    @budnix
    budnix committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    03aa2a4 View commit details
    Browse the repository at this point in the history

  2. Add tests for arrow keys navigation

    @budnix
    budnix committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    22dd0b5 View commit details
    Browse the repository at this point in the history

  3. Add tests for arrow keys navigation in RTL

    @budnix
    budnix committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c664269 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add tests for arrow keys + cmd/ctrl mods

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    595da07 View commit details
    Browse the repository at this point in the history

  2. Fix linter complains

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c652ba9 View commit details
    Browse the repository at this point in the history

  3. Add tests for the CopyPaste plugin

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9522768 View commit details
    Browse the repository at this point in the history

  4. Add tests for the MergeCells plugin

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    0e35d42 View commit details
    Browse the repository at this point in the history

  5. Simplify HiddenRows and HiddenColumns tests

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b46668d View commit details
    Browse the repository at this point in the history

  6. Simplify NeastedHeaders tests and general tests for Selection module

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7f1c916 View commit details
    Browse the repository at this point in the history

  7. Update TS definition files

    @budnix
    budnix committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ee20de7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Add support for viewport scrolling when header is highlighted

    @budnix
    budnix committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    6558ac3 View commit details
    Browse the repository at this point in the history

  2. Add support for focus navigation in nested headers

    @budnix
    budnix committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    f6c35dd View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Disable editor when the header is highlighted

    @budnix
    budnix committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ab169eb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Change how the whole rows/columns are selected

    @budnix
    budnix committed May 10, 2023
    Configuration menu
    Copy the full SHA
    d20a1e6 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Implement navigation in headers for nested headers

    @budnix
    budnix committed May 12, 2023
    Configuration menu
    Copy the full SHA
    231f12c View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Polish the code, remove the workarounds and precise navigation in nested 

    headers
    @budnix
    budnix committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4ac11ce View commit details
    Browse the repository at this point in the history

  2. Update tests for nested headers using toBeMatchToSelectionPattern 

    matcher

Add support for nested headers for mentioned Jasmine matcher.
    @budnix
    budnix committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bee3fc4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Fix highlight/focus shift bug for hidden indexes

    @budnix
    budnix committed May 16, 2023
    Configuration menu
    Copy the full SHA
    7e6f9f2 View commit details
    Browse the repository at this point in the history

  2. Fix renderable coordinates for highlight/focus shift bug

    @budnix
    budnix committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dfa0929 View commit details
    Browse the repository at this point in the history

  3. Fix highlight/focus position after changing values in index mapper

    @budnix
    budnix committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dd04135 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Add tests that covers navigation in nested headers

    @budnix
    budnix committed May 22, 2023
    Configuration menu
    Copy the full SHA
    4908a99 View commit details
    Browse the repository at this point in the history

  2. Add tests that covers navigation in collapsible columns

    @budnix
    budnix committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d49b6ae View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add tests for selection with mouse interactions

    @budnix
    budnix committed May 23, 2023
    Configuration menu
    Copy the full SHA
    26b7afb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Cover the new TableView methods with tests

    @budnix
    budnix committed May 24, 2023
    Configuration menu
    Copy the full SHA
    076a10b View commit details
    Browse the repository at this point in the history

  2. Revert support for selection extending shortcuts in headers

    @budnix
    budnix committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c93daee View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Add support for navigation moving when rows/cols are hidden

    @budnix
    budnix committed May 29, 2023
    Configuration menu
    Copy the full SHA
    e06953a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/accessibility' into feature/dev-issue-1062-part2

    @budnix
    budnix committed May 29, 2023
    Configuration menu
    Copy the full SHA
    d1d3b5b View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Add support for selection expanding when headers are selected

    @budnix
    budnix committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d911940 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Fix headers and corner highlighting when there are no rows

    @budnix
    budnix committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f49569b View commit details
    Browse the repository at this point in the history

  2. Add tests for navigation up and down in headers with corner

    @budnix
    budnix committed May 31, 2023
    Configuration menu
    Copy the full SHA
    74870b2 View commit details
    Browse the repository at this point in the history

  3. Extend selectAll methods for ability to change the focus position

    @budnix
    budnix committed May 31, 2023
    Configuration menu
    Copy the full SHA
    93e34dc View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Fix Delete keyboard shortcut when header is selected

    @budnix
    budnix committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b605eca View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Jakub Wiśniewski <jakub.wisniewski@handsontable.com>
    @budnix
    budnix and Jakub Wiśniewski committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4c99381 View commit details
    Browse the repository at this point in the history

  2. Improve the PageUp/Down keyboard shortcuts functionality

    @budnix
    budnix committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6f6a47a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature/dev-issue-1062-part2

    @budnix
    budnix committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    f163bc6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/accessibility' into feature/dev-issue-1062-part2

    @budnix
    budnix committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6834755 View commit details
    Browse the repository at this point in the history