New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undoing changes will scroll us back to the changed area in specific case #10639
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
021fccb
Developed one case and e2e tests for it
wszymanski c993004
Merge branch 'develop' into feature/dev-issue-115
wszymanski 327dc96
Merge branch 'develop' into feature/dev-issue-115
wszymanski 9a60749
Added entry to the changelog
wszymanski 0416ebd
Merge branch 'develop' into feature/dev-issue-115
wszymanski ec5f397
Merge branch 'develop' into feature/dev-issue-115
wszymanski 85e523a
Merge branch 'develop' into feature/dev-issue-115
wszymanski afb153a
Merge branch 'develop' into feature/dev-issue-115
wszymanski 569a255
Merge branch 'develop' into feature/dev-issue-115
evanSe 1c1158e
Merge branch 'develop' into feature/dev-issue-115
wszymanski 07b22c6
Merge branch 'develop' into feature/dev-issue-115
wszymanski File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"issuesOrigin": "private", | ||
"title": "Undoing changes will scroll us back to the changed area in specific case", | ||
"type": "added", | ||
"issueOrPR": 10639, | ||
"breaking": false, | ||
"framework": "none" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the
isChangedSelection
condition.It is in line with this comment, but does not meet the requirements of the original post of https://github.com/handsontable/dev-handsontable/issues/115 (it does not require selecting a different cell before hitting
cmd+z
)Is this what we want to do with it?
cc: @evanSe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jansiegel the current implementation in line with the comment is correct, @wszymanski we want a code sandbox for @krzysztofspilka review before this is merged to develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you go: https://jsfiddle.net/916z0tvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wszymanski we are good to merge