Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export for HotTableClass in React wrapper #10760

Merged
merged 7 commits into from Feb 19, 2024
Merged

Add export for HotTableClass in React wrapper #10760

merged 7 commits into from Feb 19, 2024

Conversation

evanSe
Copy link
Member

@evanSe evanSe commented Jan 31, 2024

Context

With the refactor we did around HotTable and HotTableClass for useId we did not export HotTableClass, this pull request simply exports HotTableClass.

How has this been tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. [Bug]: Index.d.ts does not export HotTableClass thus breaking React refs #10736

Affected project(s):

  • @handsontable/react

jansiegel
jansiegel previously approved these changes Feb 2, 2024
.changelogs/10736.json Outdated Show resolved Hide resolved
budnix
budnix previously approved these changes Feb 5, 2024
.changelogs/10736.json Outdated Show resolved Hide resolved
@evanSe evanSe dismissed stale reviews from budnix and jansiegel via 72bc279 February 5, 2024 08:08
Copy link

github-actions bot commented Feb 5, 2024

Launch the local version of documentation by running:

npm run docs:review fdb9d955dc4c778e186fef345cce20a27db3e73d

@evanSe evanSe merged commit 6a82ea3 into develop Feb 19, 2024
24 checks passed
@evanSe evanSe deleted the fix/issue-10736 branch February 19, 2024 13:40
@NOtherDev
Copy link
Collaborator

@evanSe Can I ask you to merge develop to feature/improved-react as this (and few others) will be useful there?

@evanSe
Copy link
Member Author

evanSe commented Feb 20, 2024

feature/improved-react

Done @NOtherDev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants