Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the mobile selection handles from showing up on "handsontable-in-handsontable" instances #10816

Merged
merged 7 commits into from Feb 26, 2024

Conversation

jansiegel
Copy link
Member

Context

This PR:

  • Prevents the mobile selection handles from showing up on "handsontable-in-handsontable" instances
  • Remove a failing mobile test on focusableElement (not longer applicable)
  • Add test cases for handsontable/dev-handsontable#1688

How has this been tested?

Added test cases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1688

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

…e-in-handsontable instances

- Remove a failing mobile test on focusableElement (not longer applicable)
- Add test cases
@jansiegel jansiegel self-assigned this Feb 23, 2024
@jansiegel jansiegel marked this pull request as ready for review February 23, 2024 14:22
Copy link

github-actions bot commented Feb 26, 2024

Launch the local version of documentation by running:

npm run docs:review ba3806b7afc8c5d4746a40a4cbd606a21db63131

@jansiegel jansiegel merged commit 85c6dcb into develop Feb 26, 2024
23 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1688 branch February 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants