Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection and context menu type annotations #5307

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

aaronbeall
Copy link
Contributor

@aaronbeall aaronbeall commented Aug 3, 2018

Context

  1. Type definitions incorrectly say getSelected() returns a Range which is an object from the DOM, but it should be CellRange which is the handsontable object described in the docs.
  2. Type annotation for context menu hooks use object which should be ContextMenu plugin instance

How has this been tested?

Tested with npm run test:types

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@aaronbeall aaronbeall changed the base branch from master to develop August 3, 2018 17:56
@aaronbeall aaronbeall changed the title Fix type annotation "Range" (from DOM) which should be "CellRange" Fix selection and context menu type annoations Aug 3, 2018
@AMBudnik
Copy link
Contributor

Thank you for sharing the PR @aaronbeall

@aaronbeall aaronbeall changed the title Fix selection and context menu type annoations Fix selection and context menu type annotations Oct 4, 2018
@wojciechczerniak wojciechczerniak added this to the December 2018 milestone Nov 5, 2018
@wojciechczerniak wojciechczerniak assigned jansiegel and pnowak and unassigned jansiegel Nov 5, 2018
@pnowak pnowak self-requested a review November 6, 2018 13:54
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pnowak pnowak modified the milestones: December 2018, November 2018 Nov 6, 2018
@pnowak pnowak merged commit 01f3cbe into handsontable:develop Nov 6, 2018
@AMBudnik
Copy link
Contributor

Always happy to inform about the PR being published. Thank you @aaronbeall ~
It's available in v 6.2.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants