New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection and context menu type annotations #5307

Merged
merged 2 commits into from Nov 6, 2018

Conversation

5 participants
@aaronbeall
Contributor

aaronbeall commented Aug 3, 2018

Context

  1. Type definitions incorrectly say getSelected() returns a Range which is an object from the DOM, but it should be CellRange which is the handsontable object described in the docs.
  2. Type annotation for context menu hooks use object which should be ContextMenu plugin instance

How has this been tested?

Tested with npm run test:types

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@aaronbeall aaronbeall changed the base branch from master to develop Aug 3, 2018

@aaronbeall aaronbeall changed the title from Fix type annotation "Range" (from DOM) which should be "CellRange" to Fix selection and context menu type annoations Aug 3, 2018

@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Aug 13, 2018

Thank you for sharing the PR @aaronbeall

@aaronbeall aaronbeall changed the title from Fix selection and context menu type annoations to Fix selection and context menu type annotations Oct 4, 2018

@wojciechczerniak wojciechczerniak added this to the December 2018 milestone Nov 5, 2018

@wojciechczerniak wojciechczerniak assigned jansiegel and pnowak and unassigned jansiegel Nov 5, 2018

@pnowak pnowak self-requested a review Nov 6, 2018

@pnowak

pnowak approved these changes Nov 6, 2018

👍

@pnowak pnowak modified the milestones: December 2018, November 2018 Nov 6, 2018

@pnowak pnowak merged commit 01f3cbe into handsontable:develop Nov 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (budnix) No new issues
Details

emilschutte added a commit to emilschutte/handsontable that referenced this pull request Nov 13, 2018

Merge branch 'develop' into arrayMapper-removeItems-speedup
* develop: (25 commits)
  Upgrade Jest testing framework (handsontable#5564)
  Fix selection and context menu type annotations (handsontable#5307)
  Fix Korean language description and remove it from Readme.
  Add extra check for numbers in Copy event (handsontable#5548)
  Remove flag from dateEditor, because it falsely points to closing the editor when it's open. (handsontable#5520)
  Feature/fix unstable contextmenu tests (handsontable#5562)
  fix for issue with ERR_ADDRESS_INVALID error in issue handsontable#5558 (handsontable#5559)
  Sorting column by right mouse click is not possible (handsontable#5556)
  Fix issues related with broken develop (handsontable#5555)
  [Column sorting] Fix for plugin's index mapper (handsontable#5552)
  More strict TypeScript definition file (handsontable#5554)
  Fix typo in columnSorting i multiColumnSorting (handsontable#5547)
  The `ColumnSorting` plugin expose common parts to the `MultiColumnSorting` plugin (handsontable#5458)
  Remove external modules from jsdoc @Dependencies tag (handsontable#5546)
  Fix typings for beforeColumnMove and beforeRowMove (handsontable#5416) (handsontable#5425)
  correctly count the syncCalculationLimit in autoRowSize (handsontable#5530)
  Add beforeOnCellMouseDown hook to autoColumnSize to keep widths. (handsontable#5508)
  - Fix mobile tests (handsontable#5529)
  fixed typo[es-MX] (handsontable#5516)
  Update documentation URLs (handsontable#5519)
  ...
@AMBudnik

This comment has been minimized.

Contributor

AMBudnik commented Nov 14, 2018

Always happy to inform about the PR being published. Thank you @aaronbeall ~
It's available in v 6.2.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment