Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLINT - no-shadow #5315

Merged
merged 4 commits into from Aug 8, 2018
Merged

ESLINT - no-shadow #5315

merged 4 commits into from Aug 8, 2018

Conversation

mrpiotr-dev
Copy link
Contributor

Context

Necessary changes to remove no-shadow from our custom .eslintrc.

How has this been tested?

  1. npm run lint
  2. should be error-free

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. Cleanup of the problems found by lint. #4536

@mrpiotr-dev mrpiotr-dev self-assigned this Aug 7, 2018
@mrpiotr-dev mrpiotr-dev assigned wszymanski and unassigned mrpiotr-dev Aug 7, 2018
@mrpiotr-dev mrpiotr-dev requested review from jansiegel and removed request for wszymanski August 8, 2018 10:01
@mrpiotr-dev mrpiotr-dev assigned jansiegel and unassigned wszymanski Aug 8, 2018
@jansiegel jansiegel assigned mrpiotr-dev and unassigned jansiegel Aug 8, 2018
@mrpiotr-dev mrpiotr-dev merged commit 8d9a39a into develop Aug 8, 2018
@mrpiotr-dev mrpiotr-dev deleted the feature/eslint-no-shadow branch August 8, 2018 12:23
@mrpiotr-dev mrpiotr-dev added this to the August 2018 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansiegel jansiegel jansiegel approved these changes

Assignees

@mrpiotr-dev mrpiotr-dev

Labels
None yet
Projects
None yet
Milestone
August 2018
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrpiotr-dev @jansiegel @wszymanski @swistach