New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix unstable contextmenu tests #5562

Merged
merged 3 commits into from Nov 5, 2018

Conversation

3 participants
@budnix
Member

budnix commented Nov 5, 2018

Context

Fix tests which consistently fails.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

budnix added some commits Oct 31, 2018

@budnix budnix requested a review from jansiegel Nov 5, 2018

@jansiegel jansiegel assigned budnix and unassigned jansiegel Nov 5, 2018

@jansiegel

This comment has been minimized.

@budnix budnix assigned jansiegel and unassigned budnix Nov 5, 2018

@jansiegel jansiegel assigned budnix and unassigned jansiegel Nov 5, 2018

@budnix budnix merged commit 3233c26 into develop Nov 5, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No manifest changes detected

@budnix budnix deleted the feature/fix-unstable-contextmenu-tests branch Nov 5, 2018

@jansiegel jansiegel added this to the November 2018 milestone Nov 7, 2018

emilschutte added a commit to emilschutte/handsontable that referenced this pull request Nov 13, 2018

Merge branch 'develop' into arrayMapper-removeItems-speedup
* develop: (25 commits)
  Upgrade Jest testing framework (handsontable#5564)
  Fix selection and context menu type annotations (handsontable#5307)
  Fix Korean language description and remove it from Readme.
  Add extra check for numbers in Copy event (handsontable#5548)
  Remove flag from dateEditor, because it falsely points to closing the editor when it's open. (handsontable#5520)
  Feature/fix unstable contextmenu tests (handsontable#5562)
  fix for issue with ERR_ADDRESS_INVALID error in issue handsontable#5558 (handsontable#5559)
  Sorting column by right mouse click is not possible (handsontable#5556)
  Fix issues related with broken develop (handsontable#5555)
  [Column sorting] Fix for plugin's index mapper (handsontable#5552)
  More strict TypeScript definition file (handsontable#5554)
  Fix typo in columnSorting i multiColumnSorting (handsontable#5547)
  The `ColumnSorting` plugin expose common parts to the `MultiColumnSorting` plugin (handsontable#5458)
  Remove external modules from jsdoc @Dependencies tag (handsontable#5546)
  Fix typings for beforeColumnMove and beforeRowMove (handsontable#5416) (handsontable#5425)
  correctly count the syncCalculationLimit in autoRowSize (handsontable#5530)
  Add beforeOnCellMouseDown hook to autoColumnSize to keep widths. (handsontable#5508)
  - Fix mobile tests (handsontable#5529)
  fixed typo[es-MX] (handsontable#5516)
  Update documentation URLs (handsontable#5519)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment