Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'getCommentAtCell' method into typings #6127

Merged
merged 2 commits into from Jul 19, 2019

Conversation

wertstein
Copy link
Contributor

Context

On my recent commercial Angular project, I use getCommentAtCell method and it is missing in typings. I have to use a workaround like plugin['getCommentAtCell']().

How has this been tested?

I added getCommentAtCell method to typings file on my local machine and snippethot.getPlugin('comments').getCommentAtCell(1, 2); has no TSLint errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@AMBudnik
Copy link
Contributor

Thank you for sending the change and signing CLA.

Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wertstein for improvement.
But could you correct that this method can return not only a string but also an undefined/void one?

@pnowak pnowak self-requested a review July 19, 2019 06:24
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants