Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing missing 'init' and 'validateCell' methods to the Hand… #6266

Merged
merged 5 commits into from
Oct 7, 2019
Merged

Add the missing missing 'init' and 'validateCell' methods to the Hand… #6266

merged 5 commits into from
Oct 7, 2019

Conversation

jansiegel
Copy link
Member

Add the missing missing 'init' and 'validateCell' methods to the Handsontable types definition file.

pnowak
pnowak reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to the alphabetical order. So init should be before isColumnModificationAllowed.

And maybe we should add validateCell to docs?

@pnowak pnowak assigned jansiegel and unassigned pnowak Sep 16, 2019
@jansiegel jansiegel requested a review from pnowak October 7, 2019 12:45
pnowak
pnowak approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jansiegel jansiegel merged commit 2070567 into develop Oct 7, 2019
@jansiegel jansiegel deleted the feature/addInitToTypedef branch October 7, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowak pnowak pnowak approved these changes

Assignees

@jansiegel jansiegel

Labels
Status: Released TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jansiegel @pnowak @AMBudnik