Fixed #665 and #630 #666
Closed
Fixed #665 and #630 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+D should work similar to Excel Ctrl-Arrow and Ctrl-Shift-Arrow Ex. Ctrl+Right Arrow should jump to next filled column similarly Ctrl+Shift+Arrow should jump to next filled column
in this case we have to jump to the continuously last filled column or row
|
Thanks for the contribution. Would it be possible for you to add test cases to the changes you made? Otherwise it may take some time until I merge this. |
Treating them as empty
Added few keycodes and ctrl+ handling in SpecHelper.js Added testcases for Ctrl+D Ctrl+arrow_right/arrow_left/arrow_down/arrow_up Ctrl+Shift+arrow_right/arrow_left/arrow_down/arrow_up
|
Thanks to you for this wonderful javascript plugin. I have added the testcases. |
|
Are you planning to merge it ? |
|
Thanks, yes. Give us few more days please :) |
|
If i redo the changes on your latest versions, Will you be accepting pull request. |
|
Thank you for this pull request. I know that 3 years in dev environment feels like ages but maybe you would like to recheck the code as the branch has some conflicts it would be great! Currently, I have to close it but be more than happy to see this two features running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+D should work similar to Excel
Ctrl-Arrow and Ctrl-Shift-Arrow
Ex. Ctrl+Right Arrow should jump to next filled column
similarly Ctrl+Shift+Arrow should jump to next filled column