Using index mappers instead of own created storage for states of filtering #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f4cc152:
|
…g newly introduced functions #6830
Additionally, the commit updates the TS definition. Issue: #6830
The commit fixes a bug which occurs in column filtering state indication within the columns' headers. The ConditionCollection class while closing the dropdown menu unregistered the "filteringStates" map, where shouldn't.
|
While testing the "by_value" component I've found another bug where the content of the component is not refreshed after columns reorder. |
The commit removes the stateSaver mixin (which wasn't used broadly) and directly implements the IndexMapper architecture into the Filters UI components. Moreover, the changes remove the "hiddenRowsCache" map which, as it turned out, is not necessary at all. The UI components' hidden state can be calculated on the fly while showing the Dropdown menu. Issue: #6830
Issue: #6830
The code unnecessary call hide/show methods where while components' state restoration the visibility state is already set. Issue: #6830
mrpiotr-dev
reviewed
Nov 20, 2020
Filters are passive, so I'd say no. You can call the |
mrpiotr-dev
approved these changes
Nov 20, 2020
wojciechczerniak
dismissed
budnix’s stale review
@budnix took over this PR, should no longer be a reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PR #7276 introduced a new kind of Index Map. I'm using it here for purpose of storing and managing states of filtering for particular columns. The
Filtersplugin has been adjusted to use the only Index Map (all unnecessary parts of code has been removed). What's more:clearConditionsmethod ofConditionCollectionelement. There was a function that cleared conditions at the specified column index but without clearing stack order (stored in separate array). Since the order of columns is stored inside the Index Mapper there is no way to threaten it separately. Thus, some parts of the code have been changed. HooksbeforeClearandafterClearhave been removed whileafterRemovehook has been introduced.isMatchInConditionsmethod ofConditionCollectionelement. It will need an argument. Function without an argument hasn't been used internally.clearValue- for newly created Index Map within Using index mappers instead of own created storage for states of sorting #7276.menu.
stateSavermixing which causes the components state misalignment after column reordering. The mixin is removed and the state management from now on is implemented directly into the UI Base component.How has this been tested?
Manual tests for alter actions.
Types of changes
Related issue(s):
Checklist: