Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional marking for params in setDataAtCell [DOCS] #7346

Closed
wants to merge 1 commit into from

Conversation

scarletfog
Copy link
Contributor

@scarletfog scarletfog commented Oct 18, 2020

Context

Two params are no longer optional, remove the misleading information.

Types of changes

  • Improvement in the documentation

Related issue(s):

  1. https://github.com/handsontable/docs/issues/181

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbf840e:

Sandbox Source
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true

@AMBudnik
Copy link
Contributor

OK, so I think that we can close this PR and chat about possible code samples at https://github.com/handsontable/docs/issues/181

@scarletfog
Copy link
Contributor Author

@AMBudnik let's keep it. I will use it to add examples

@wojciechczerniak wojciechczerniak marked this pull request as draft November 5, 2020 21:06
@wojciechczerniak
Copy link
Contributor

For adding examples we should create a new PR.

@AMBudnik AMBudnik removed their request for review September 17, 2021 11:44
@budnix budnix deleted the correct_optional_params/issue-181 branch June 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants