Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Adding docs changes related to the Moment.js dependency update #9409

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Docs: Adding docs changes related to the Moment.js dependency update #9409

merged 2 commits into from
Apr 22, 2022

Conversation

kirszenbaum
Copy link
Contributor

This PR:

  • Updates Moment.js version numbers mentioned in the docs
  • Edits the changelog entry

@kirszenbaum kirszenbaum self-assigned this Apr 21, 2022
@kirszenbaum kirszenbaum added the Docs: Content Issues related to Handsontable's documentation content label Apr 21, 2022
@github-actions
Copy link

Launch the local version of documentation by running:

npm run docs:review 8026c5112c2a0a9b6cdb3ef4e8e1109876337063

jansiegel
jansiegel requested changes Apr 22, 2022
View reviewed changes
.changelogs/9381.json Outdated
@@ -1,5 +1,5 @@
{
"title": "Update MomentJS dependency to 2.29.2.",
"title": "Updated the Moment.js dependency from `2.24.0` to `2.29.3`, improving Handsontable's date format matching.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather concentrate on the security aspect of the change, as it's not exactly clear if the change on Moment's side is something we want or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jansiegel - sure (I followed this but took it out of context)

How about this: a430fda (not to sound too alarmist)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jansiegel - sure (I followed this but took it out of context)

How about this: a430fda (not to sound too alarmist)

Oh, I missed this. Still, I'd rather keep the security information in the changelog, and maybe elaborate about the format matching in the release notes/blog post. WDYT?

a430fda looks great to me 👍

docs/next/guides/building-and-testing/packages.md
@@ -30,7 +30,7 @@ If you are a "Bob the Builder" kind of hacker, you will need to load Handsontabl
```html
<!-- Required dependencies (as external scripts) -->
<link href="https://cdn.jsdelivr.net/npm/pikaday@1.5.1/css/pikaday.min.css" rel="stylesheet">
<script src="https://cdn.jsdelivr.net/npm/moment@2.20.1/moment.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/moment@2.29.3/moment.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I totally forgot it's linked from the cdn in the docs 👍

@kirszenbaum kirszenbaum merged commit 07459a3 into feature/snyk-fix-c3454c61088848cba1ba001bfb76870c Apr 22, 2022
@kirszenbaum kirszenbaum deleted the docs/feature/snyk-fix-c3454c61088848cba1ba001bfb76870c branch April 22, 2022 08:23
jansiegel added a commit that referenced this pull request Apr 22, 2022
@budnix @jansiegel
Update MomentJS dependency (#9382)
90dfc4f 
* Update MomentJS dependency

Origin: #9376

* Updating momentJS fixes an issue with sorting date values

The commit fixes the tests.

* Fix dateFormat pattern

* - Correct the date format on the remaining cases in multiColumnSorting.spec.js.

* Bump moment dependency for the 'handsontable' workspace and the root directory.

* Docs: Adding docs changes related to the Moment.js dependency update (#9409)

Co-authored-by: Jan Siegel <jansiegel@users.noreply.github.com>
Co-authored-by: Jan Siegel <js.ziggle@gmail.com>
Co-authored-by: Kuba Jakub <jakub.wisniewski@handsontable.com>
jansiegel added a commit that referenced this pull request Apr 22, 2022
@budnix @jansiegel
Update MomentJS dependency (#9382)
206fe29 
* Update MomentJS dependency

Origin: #9376

* Updating momentJS fixes an issue with sorting date values

The commit fixes the tests.

* Fix dateFormat pattern

* - Correct the date format on the remaining cases in multiColumnSorting.spec.js.

* Bump moment dependency for the 'handsontable' workspace and the root directory.

* Docs: Adding docs changes related to the Moment.js dependency update (#9409)

Co-authored-by: Jan Siegel <jansiegel@users.noreply.github.com>
Co-authored-by: Jan Siegel <js.ziggle@gmail.com>
Co-authored-by: Kuba Jakub <jakub.wisniewski@handsontable.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansiegel jansiegel jansiegel approved these changes

Assignees

@kirszenbaum kirszenbaum

Labels
Docs: Content Issues related to Handsontable's documentation content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kirszenbaum @jansiegel