Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu does not show up #51

Closed
warpech opened this issue Dec 29, 2017 · 10 comments
Closed

Context menu does not show up #51

warpech opened this issue Dec 29, 2017 · 10 comments
Labels
Milestone

Comments

@warpech
Copy link
Member

warpech commented Dec 29, 2017

Steps to reproduce

  1. Install hot-table locally using bower
  2. Run a local server (I use Polyserve)
  3. Go to the demo page index.html
  4. Right-click on any cell

Expected

A context menu should open because the attribute context-menu is present.

Actual

Context menu does not open but I can see that the vertical scrollbar moves a bit. It seems as if the context menu opens unstyled outside of the browser viewport.

Tested using Chrome.

@AMBudnik AMBudnik added the Bug label Jan 2, 2018
warpech added a commit that referenced this issue Jan 31, 2018
…stylesheets manually, especially given that they are included in `hot-table-style.html` (#51)

Solution: remove explicit loading of these stylesheets from <head> and do that from a script at the bottom of `hot-table-style.html`

Also, update the URLs of Handsontable PRO to the current version
@warpech
Copy link
Member Author

warpech commented Jan 31, 2018

I pushed a fix to a branch. It is a work in progress, I will make a PR when it's ready.

@icaromro
Copy link

icaromro commented May 11, 2018

Any news on this? I'm having this problem on version 2.0.0. When right clicking for the context menu I can see that the vertical scroll bar move and when I go to the end of the page the context menu is opened there and I get the following error message:
ngHandsontable.js:25 Uncaught TypeError: Cannot set property 'isHotTableEnv' of undefined

@AMBudnik
Copy link

I am sorry but we did not update the hot-table recently. We'll do it in the first spare minute.

@warpech
Copy link
Member Author

warpech commented Jun 19, 2018

My branch that fixes the problem: https://github.com/handsontable/hot-table/tree/upgrade-hot

@handsontable/core pls finish this as a proper PR whenever possible.

@wojciechczerniak wojciechczerniak added this to the July 2018 milestone Jun 19, 2018
@ketan-navadiya
Copy link

Could anyone please provide any workaround for "ContextMenu" problem? We are using Hansontable Pro version 4.0.0 with the Hot table. I am facing the same issue.

We really needed the solution because earlier we used a free version of Handsontable and ContextMenu function was working fine. Now, Our Client decided to use Pro version to add an extra feature if we didn't get any workaround or PR then we need to move back to the free version because our lots of functionality depend on "ContextMenu" feature.

@AMBudnik
Copy link

Hi @ketan-navadiya

the solution provided by @warpech will be pulled in the next version of Handsontable (PRO and CE).

@ketan-navadiya
Copy link

Hi @AMBudnik, Thanks for the response.
When will be this next version release?

@AMBudnik
Copy link

It is planned for 11th of July.

@ketan-navadiya
Copy link

@AMBudnik okay, Thanks.

@budnix
Copy link
Member

budnix commented Aug 14, 2018

Fixed and released in 1.0.0

@budnix budnix closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants