Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheet name case sensitivity #66

Closed
3 tasks
wojciechczerniak opened this issue Dec 6, 2019 · 1 comment
Closed
3 tasks

Sheet name case sensitivity #66

wojciechczerniak opened this issue Dec 6, 2019 · 1 comment
Labels
Breaking Change Will need a major release ODFF Conformance ODDF 1.3 Evaluator requirement ODFF SGE ODDF 1.3 Small Group Evaluator requirement
Milestone

Comments

@wojciechczerniak
Copy link
Contributor

Description

Extracted from #12

We should compare sheet names as case-insensitive and normalize them (to the one created with renameSheet or addSheet) on formula save as we do with other references.

  • Normalize sheetName on formula save
  • API methods getSheetID, removeSheet, doesSheetExist, isItPossibleToAddSheet, isItPossibleToRemoveSheet etc should be case-insensitive as well
  • As @swistak35 mentioned in Worksheet reference #12 (comment) we have to propagate the change to unparser and any other internal use

Spec

I dodn't found special reference to sheet names. They are treated as any other reference.

@wojciechczerniak wojciechczerniak added ODFF SGE ODDF 1.3 Small Group Evaluator requirement ODFF Conformance ODDF 1.3 Evaluator requirement labels Dec 6, 2019
@wojciechczerniak wojciechczerniak added this to the December 2019 milestone Dec 6, 2019
@wojciechczerniak wojciechczerniak added the Breaking Change Will need a major release label Dec 6, 2019
@swistak35 swistak35 self-assigned this Dec 13, 2019
swistak35 added a commit that referenced this issue Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Will need a major release ODFF Conformance ODDF 1.3 Evaluator requirement ODFF SGE ODDF 1.3 Small Group Evaluator requirement
Projects
None yet
Development

No branches or pull requests

2 participants