Add support for HYPERLINK (hyperformula) #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prev impl did not work for any params to HYPERLINK that were not strings - was also not a way that i could find to re parse the args from the Ast - so stuffing the hyperlink into the FormulaCellVertex seemed to be the next best option
This was referenced Mar 29, 2023
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thilgen
changed the title
Closed
|
@thilgen Thank you very much for your involvement in the project. We need to focus on the scope of the upcoming release, and currently, we have no capacity to review your pull request. I can assure you that we will check it out as soon as we can. |
|
TBD: Keyboard bindings, context menu, and docs |
sequba
reviewed
Apr 27, 2023
sequba
reviewed
Apr 27, 2023
…nto hyperlink-formula
- To protect against batch operations
sequba
requested changes
May 5, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1216 +/- ##
========================================
Coverage 97.18% 97.19%
========================================
Files 165 166 +1
Lines 14218 14238 +20
Branches 2961 2965 +4
========================================
+ Hits 13818 13838 +20
Misses 400 400
|
sequba
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
HYPERLINK is a formula provided by Google Sheets (documentation); MS Excel (documentation); and is included in the Open Document Format for Office Applications (documentation)
For more information
HandsontableChanges: Add support for HYPERLINK (handsontable) handsontable#10314How has this been tested?
Unit Tests (100% coverage for new files and new paths*) and Test Application
HyperFormula.tswhich has too many missing paths to determine new impacts.Will try and start looking at increasing coverage for this file in the future so it does not become completely ignorable for codecov stats.Code Coverage: Improve coverage for HyperFormula.ts (92.38% -> 99.65%) #1218Types of changes
Related issues:
Checklist: