Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance benchmarks #1366

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Improve performance benchmarks #1366

merged 7 commits into from
Jan 30, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jan 10, 2024

Context

  • make CRUD benchmarks run 100 times (same as the basic benchmarks)
  • refactor the benchmarking code

How did you test your changes?

  • verified that performance benchmarks are still run by GH actions
  • verified that the results after the change are similar to previous results

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation
  • Change to the internal tooling

Related issues:

  1. Fixes Increase number of runs for all performance benchmarks #1315

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba linked an issue Jan 10, 2024 that may be closed by this pull request
@sequba sequba self-assigned this Jan 10, 2024
@sequba sequba changed the title WIP Improve performance benchmarks Jan 10, 2024
Copy link

github-actions bot commented Jan 10, 2024

Performance comparison of head (73ee649) vs base (fcafd79)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 557.65 | 601.45 |  +7.85%
                                      Sheet B |  189.5 | 189.06 |  -0.23%
                                      Sheet T |  163.3 | 162.24 |  -0.65%
                                Column ranges | 576.72 | 573.64 |  -0.53%
Sheet A:  change value, add/remove row/column |     39 |  16.51 | -57.67%
 Sheet B: change value, add/remove row/column |    307 | 147.15 | -52.07%
                   Column ranges - add column |    162 | 166.67 |  +2.88%
                Column ranges - without batch |    496 | 488.82 |  -1.45%
                        Column ranges - batch |    233 | 137.51 | -40.98%

@sequba sequba marked this pull request as ready for review January 16, 2024 16:35
@sequba sequba requested a review from evanSe January 16, 2024 16:35
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcafd79) 97.36% compared to head (73ee649) 97.36%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1366   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files          169      169           
  Lines        14423    14423           
  Branches      3023     3023           
========================================
  Hits         14043    14043           
  Misses         380      380           

@sequba sequba merged commit 3a7aafb into develop Jan 30, 2024
23 checks passed
@sequba sequba deleted the feature/issue-1315 branch January 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase number of runs for all performance benchmarks
2 participants